x86-64: Inline small array copy size for int and long arrays #7362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xdaryl May I ask you to review this change? Thank you! |
(1)
Inline small array copy size without using `rep movs`
for int array and long array
- If AVX-512 is supported and copy size <= 128 bytes,
the inlined copy sequence is used.
- If AVX is supported, the threshold for inlined sequence
is 64 bytes instead.
- The enhancement for 32 bit and 64 bit arrays will be reused
in the downstream OpenJ9 project for reference arrays.
(2)
Refactor char array enhancement implementation to support
both `rep movsw` and `rep movsd` if the copysize is greater
than the supported enhancement threshold.
(3)
Add the following options to disable the enhancement
- `disableArrayCopyIntArrayInlineSmallSizeWithoutREPMOVS`:
disable the enhancement for int array
- `disableArrayCopyLongArrayInlineSmallSizeWithoutREPMOVS`:
disable the enhancement for long array
- `disableArrayCopyReferenceArrayInlineSmallSizeWithoutREPMOVS`:
disable the enhancement for reference array, which will be
implemented in downstream project OpenJ9.
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
a7ehuo
force-pushed
the
system-arraycopy-perf-12-int-long
branch
from
e26efe4
to
2a2e130
Compare
a7ehuo
changed the title
|
Jenkins build xlinux,xmac,win,x32linux |
0xdaryl
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1)
Inline small array copy size without using
rep movsfor int array and long array(2)
Refactor char array enhancement implementation to support both
rep movswandrep movsdif the copysize is greater than the supported enhancement threshold.(3)
Add the following options to disable the enhancement
disableArrayCopyIntArrayInlineSmallSizeWithoutREPMOVS: disable the enhancement for int arraydisableArrayCopyLongArrayInlineSmallSizeWithoutREPMOVS: disable the enhancement for long arraydisableArrayCopyReferenceArrayInlineSmallSizeWithoutREPMOVS: disable the enhancement for reference array, which will be implemented in downstream project OpenJ9.