Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xlinux platforms to use Cent7 for JDK15+ compiles #10138

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Update xlinux platforms to use Cent7 for JDK15+ compiles #10138

merged 2 commits into from
Jul 30, 2020

Conversation

jdekonin
Copy link
Contributor

@jdekonin jdekonin commented Jul 9, 2020

Signed-off-by: Joe deKoning joe_dekoning@ca.ibm.com

@jdekonin
Copy link
Contributor Author

jdekonin commented Jul 9, 2020

@Jenkins compile xlinux jdk8,jdk15

@jdekonin
Copy link
Contributor Author

jdekonin commented Jul 9, 2020

fyi @pshipton

@jdekonin
Copy link
Contributor Author

jdekonin commented Jul 9, 2020

jenkins test sanity.functional xlinux jdk8,jdk15

@jdekonin
Copy link
Contributor Author

jdekonin commented Jul 9, 2020

jenkins test sanity.functional xlinux jdk15

@pshipton
Copy link
Member

pshipton commented Jul 9, 2020

/home/jenkins/set_gcc7.5.0_env: No such file or directory

@jdekonin jdekonin force-pushed the master branch 2 times, most recently from 997de7f to 24bfac8 Compare July 16, 2020 14:08
@jdekonin
Copy link
Contributor Author

jenkins test sanity.functional xlinux jdk8,jdk15

@jdekonin
Copy link
Contributor Author

jenkins test sanity.functional xlinux jdk15

1 similar comment
@jdekonin
Copy link
Contributor Author

jenkins test sanity.functional xlinux jdk15

@jdekonin
Copy link
Contributor Author

JDK15+ testing needs to be omitted on cent6 x86 nodes; glibc issue otherwise.

@jdekonin
Copy link
Contributor Author

jenkins test sanity.functional xlinux jdk8,jdk15

AdamBrousseau added a commit to AdamBrousseau/openj9 that referenced this pull request Jul 29, 2020
@AdamBrousseau
Set extraTestLabels per SDK_VERSION
5644a38 
- Our use case to set by target is no longer needed
  but a new use case to set by version is.

[skip ci]
Related eclipse-openj9#10138 eclipse-openj9#9855

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@AdamBrousseau AdamBrousseau mentioned this pull request Jul 29, 2020
Closed
jdekonin and others added 2 commits July 29, 2020 17:09
@jdekonin
Update xlinux platforms to use Cent7 for JDK15+ compiles
9f11d23 
* [skip ci]
* Resolves eclipse-openj9#9855
* add extra test labels to avoid running on cent6 systems
*  due to glibc difference

Signed-off-by: Joe deKoning <joe_dekoning@ca.ibm.com>
@AdamBrousseau @jdekonin
Set extraTestLabels per SDK_VERSION
2bc8787 
- Our use case to set by target is no longer needed
  but a new use case to set by version is.

[skip ci]
Related eclipse-openj9#10138 eclipse-openj9#9855

Signed-off-by: Adam Brousseau <adam.brousseau88@gmail.com>
@jdekonin
Copy link
Contributor Author

jenkins test sanity.functional xlinux jdk8,jdk15

@AdamBrousseau
Copy link
Contributor 

17:14:56  TESTS:'[sanity.functional:[extraTestLabels:!sw.os.cent.6, testFlag:, keepReportDir:false, buildList:]]'

I think this is good now. If you want I can close my PR and we can merge this with both changes.

@jdekonin jdekonin changed the title WIP: Update xlinux platforms to use Cent7 for JDK15+ compiles Update xlinux platforms to use Cent7 for JDK15+ compiles Jul 30, 2020
@jdekonin
Copy link
Contributor Author

jdekonin commented Jul 30, 2020 •
edited
Loading

@pshipton @DanHeidinga Cent7 x86 JDK15 compile and testing is now functional. This is ready for you review/merge.

EDIT: Not to imply testing is 100% clean on JDK15 x86, just that test pipelines for JDK15 will specifically not target Cent6 x86 hosts where the Cent7 compiled binary will not run due to glibc differences.

@pshipton pshipton self-assigned this Jul 30, 2020
@pshipton pshipton merged commit 777ea91 into eclipse-openj9:master Jul 30, 2020
@pshipton pshipton mentioned this pull request Jul 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamBrousseau AdamBrousseau AdamBrousseau approved these changes

@pshipton pshipton pshipton approved these changes

Assignees

@pshipton pshipton

Labels
comp:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile xlinux jdk15+ on CentOS 7
3 participants
@jdekonin @pshipton @AdamBrousseau