Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename master/slave for omr dependent files #10174

Merged
merged 2 commits into from
Jul 21, 2020
Merged

Rename master/slave for omr dependent files #10174

merged 2 commits into from
Jul 21, 2020

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Jul 15, 2020 •
edited
Loading

OMR dependent: eclipse/omr#5398

Related to: #10071

There are more replacements but I've tried to make this pr "smaller" by including mostly dependent omr changes.

Everything is a direct replacement slave->worker and master->main.

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

@pshipton
Copy link
Member

The copyrights need to be updated.

@theresa-m
Replace slave with worker
e69958d 
omr dependent

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Replace master with main
842b0ef 
omr dependent

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m theresa-m force-pushed the rename_masterthread_2_omronly branch 2 times, most recently from 109c6a7 to 842b0ef Compare July 15, 2020 16:58
@theresa-m theresa-m changed the title Rename master/slave for GC files Rename master/slave for omr dependent files Jul 15, 2020
@theresa-m theresa-m mentioned this pull request Jul 15, 2020
Merged
@theresa-m
Copy link
Contributor Author

Updated copyrights and opened dependent OMR pr.

@theresa-m theresa-m mentioned this pull request Jul 15, 2020
Closed
@SueChaplain
Copy link
Contributor

@theresa-m - we believe that this work will result in a change needed at the user docs where system output shows GC master/slave. See https://www.eclipse.org/openj9/docs/tool_jdmpview/#example.

Please can you open a doc issue so that we don't forget to do this when the work is complete?

@theresa-m theresa-m mentioned this pull request Jul 20, 2020
Closed
@theresa-m
Copy link
Contributor Author

@theresa-m - we believe that this work will result in a change needed at the user docs where system output shows GC master/slave. See https://www.eclipse.org/openj9/docs/tool_jdmpview/#example.

Please can you open a doc issue so that we don't forget to do this when the work is complete?

eclipse-openj9/openj9-docs#605
I'll make sure to update when this is merged.

@theresa-m
Copy link
Contributor Author

any takers for review?

@pshipton
Copy link
Member

jenkins compile aix,xlinux,osx,win jdk8,jdk11 depends eclipse/omr#5398

@pshipton
Copy link
Member

jenkins test sanity ppc64_aix,x86-64_linux,x86-64_linux_xl,ppc64le_linux,ppc64le_linux_xl,s390x_linux,s390x_linux_xl,x86-64_windows,x86-32_windows,x86-64_mac jdk8,jdk11 depends eclipse/omr#master

@dmitripivkine dmitripivkine self-requested a review July 21, 2020 20:15
dmitripivkine
dmitripivkine approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@dmitripivkine dmitripivkine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very accurate work, thank you

@pshipton pshipton merged commit 8bcd19b into eclipse-openj9:master Jul 21, 2020
@pshipton pshipton self-assigned this Jul 21, 2020
@theresa-m theresa-m deleted the rename_masterthread_2_omronly branch July 20, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@dmitripivkine dmitripivkine dmitripivkine approved these changes

Assignees

@pshipton pshipton

Labels
comp:gc comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theresa-m @pshipton @SueChaplain @dmitripivkine