Move lowering of ArrayStoreCHK to lowerTreesPreChildrenVisit #10220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowering of ArrayStoreCHK depends on its source and destination operands. However, compression/decompression of those child operands might be performed by lowering afterwards, leaving the lowered ArrayStoreCHK trees in an incomplete state. Fixed this by moving the call to lowerArrayStoreCHK into lowerTreesPreChildrenVisit, to ensure compression sequences are generated afterwards. This also eliminates the need for the findArrayStoreCHKOperands method, which was attempting to perform pattern matching of the ArrayStoreCHK tree after compression/ decompression had been applied to its operands. Signed-off-by: Henry Zongaro <zongaro@ca.ibm.com>
|
Andrew @andrewcraik, may I ask you to review this change? Leo @Leonardo2718, @a7ehuo Annabelle: FYI |
andrewcraik
added
bug
comp:jit
project:valhalla
andrewcraik
approved these changes
Jul 24, 2020
|
Jenkins test sanity all jdk14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering of
ArrayStoreCHKdepends on its source and destination operands. However, compression/decompression of those child operands might be performed by lowering afterwards, leaving the loweredArrayStoreCHKtrees in an incomplete state.Fixed this by moving the call to
lowerArrayStoreCHKintolowerTreesPreChildrenVisit, to ensure compression sequences are generated afterwards. This also eliminates the need for thefindArrayStoreCHKOperandsmethod, which was attempting to perform pattern matching of the ArrayStoreCHK tree after compression/decompression had been applied to its operands.Signed-off-by: Henry Zongaro zongaro@ca.ibm.com