Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Add files needed for linux aarch64 build #4350

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jan 18, 2019

This commit adds files needed for building for linux aarch64.

Signed-off-by: knn-k konno@jp.ibm.com

buildspecs/linux_aarch64.spec Outdated Show resolved Hide resolved
@keithc-ca
Copy link
Contributor

I think this is ready. @knn-k, please remove the WIP prefix from the heading after you've made any final adjustments, if any.

@knn-k knn-k changed the title WIP: AArch64: Add files needed for linux aarch64 build AArch64: Add files needed for linux aarch64 build Jan 24, 2019
@knn-k
Copy link
Contributor Author

knn-k commented Jan 24, 2019

Thank you @keithc-ca. I removed the WIP. I will add further changes in other PRs.

<project id="compiler"/>
</source>
<flags>
<flag id="arch_arm" value="true"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be true for aarch64

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing it out. I corrected it, and the j9vm_arch_*=section in makelib/mkconstants.mk is now OK.

@knn-k knn-k force-pushed the aarch64build1 branch 2 times, most recently from 892d356 to c01d80f Compare January 24, 2019 07:01
This commit adds files needed for building for linux aarch64.

Signed-off-by: knn-k <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Jan 24, 2019

I changed configure_linux_aarch64.mk for --enable-OMR_ENV_DATA64 and CONFIGURE_ARGS += 'OMR_TARGET_DATASIZE=64'.

@keithc-ca
Copy link
Contributor

Jenkins compile zlinux jdk11

@keithc-ca keithc-ca merged commit 90b9e7b into eclipse-openj9:master Jan 25, 2019
@knn-k knn-k deleted the aarch64build1 branch January 27, 2019 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants