Adding XML Parser to Docker containers #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build docker x86 ubuntu16 |
|
jenkins build docker s390x ubuntu16 |
|
jenkins build docker ppc64le centos7 |
samuel-rubin
force-pushed
the
add_xml_parser_docker
branch
from
5cde97f
to
273a1f5
Compare
|
jenkins build docker ppc64le centos7 |
|
jenkins build docker x86 centos6.9 |
samuel-rubin
force-pushed
the
add_xml_parser_docker
branch
from
273a1f5
to
58d22c9
Compare
|
I got the tests to compile on:
|
samuel-rubin
changed the title
|
@AdamBrousseau for review |
This is needed in order for our tests to work Moved the dependencies for git to the install section [skip ci] Signed-off-by: Samuel Rubin <samuel.rubin@ibm.com>
samuel-rubin
force-pushed
the
add_xml_parser_docker
branch
from
58d22c9
to
eafdca1
Compare
AdamBrousseau
approved these changes
Feb 26, 2019
smlambert
approved these changes
Feb 27, 2019
|
I made a mistake. The expat library is needed for all of the ubuntu18s and ubuntu16 on ppc. This caused those docker files to fail their build. I have created #4916 to fix this issue |
samuel-rubin
added a commit
to samuel-rubin/openj9
that referenced
this pull request
Feb 28, 2019
Missing expat library caused some of the containers to fail their build Also moved the dependencies for git to the top and identified them [skip ci] Related eclipse-openj9#4870 Signed-off-by: Samuel Rubin <samuel.rubin@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed in order for our tests to work
[skip ci]
Signed-off-by: Samuel Rubin samuel.rubin@ibm.com