Modify SCC test to make it compatible with JITServer #6681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`testSCCMLSoftmx_1` from `extended.functional` currently fails in JITServer mode, because it expects to find SCC hints produced due to compilation exceeding an expensive memory compilation threshold. That does not happen for a remote compilation, because it uses very little memory on the client. Make the test pass by manually setting the threshold to a small value that will definitely be exceeded by a remote compilation. Signed-off-by: Dmitry Ten <Dmitry.Ten@ibm.com>
|
@mpirvu fyi |
|
Linking the personal build tests here |
|
travis-ci failed due to infra: |
smlambert
approved these changes
Aug 9, 2019
|
Can one of the admins verify this patch? |
|
JITServer doesn't run into this issue anymore, so I'm closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testSCCMLSoftmx_1fromextended.functionalcurrentlyfails in JITServer mode, because it expects to find SCC hints
produced due to compilation exceeding an expensive memory
compilation threshold. That does not happen for a remote compilation,
because it uses very little memory on the client.
Make the test pass by manually setting the threshold to a small value
that will definitely be exceeded by a remote compilation.