Work around compiler bug when reading SCC hints

[ymanton]

XL C++ 13.1.3 on AIX generates incorrect code for the line in question.

The stack location containing the hint we fetch from the SCC is read and
tested for ==0 before it is written to, so we intermittently take the wrong
path and try to update a non-existent hint, which fails.

Signed-off-by: Younes Manton ymanton@ca.ibm.com

Building OpenJ9 with this patch and disassembling the JIT shows that the compiler now generates the correct sequence of instructions.

Fixes: #7045

[ymanton]

Jenkins test sanity.extended all jdk8,jdk11

[mpirvu]

LGTM

[mpirvu]

Infra failures:

20:56:20  gmake[1]: Entering directory '/home/u0020236/workspace/Test_openjdk11_j9_sanity.extended_ppc64_aix_Personal/openjdk-tests'
20:56:20  gmake[1]: autoGen.mk: A file or directory in the path name does not exist.
20:56:20  gmake[1]: *** No rule to make target 'autoGen.mk'.  Stop.
20:56:20  gmake[1]: Leaving directory '/home/u0020236/workspace/Test_openjdk11_j9_sanity.extended_ppc64_aix_Personal/openjdk-tests'
20:56:20  settings.mk:255: recipe for target 'compile-..' failed
20:56:20  gmake: *** [compile-..] Error 2

[mpirvu]

Jenkins test sanity.extended all jdk8,jdk11

[pshipton]

Jenkins test sanity,extended all jdk8,jdk11

[pshipton]

Note the testvmcheck failures are a known problem, will be fixed by #7148

[mpirvu]

AIX Java11 extended.functional - TestAttachErrorHandling_0

===============================================
Running test TestAttachErrorHandling_0 ...
===============================================
TestAttachErrorHandling_0 Start Time: Wed Sep 18 16:13:11 2019 Epoch Time (ms): 1568841191756
variation: NoOptions
JVM_OPTIONS: -Xcompressedrefs 
[IncludeExcludeTestAnnotationTransformer] [INFO] exclude file is /home/u0020236/workspace/Test_openjdk11_j9_extended.functional_ppc64_aix_Personal/openjdk-tests/TestConfig/scripts/testKitGen/../../../../jvmtest/TestConfig/resources/excludes/latest_exclude_11.txt

It's not clear to me what kind of error this is.

[mpirvu]

More info on the error above:

 org.openj9.test.attachAPI.TestAttachErrorHandling.testPrematureSocketClose
 Error Details
com.sun.tools.attach.AttachNotSupportedException: acknowledgement timeout from 5898284 on port 61694
 Stack Trace
      java.lang.AssertionError: com.sun.tools.attach.AttachNotSupportedException: acknowledgement timeout from 5898284 on port 61694
at org.testng.Assert.fail(Assert.java:96)
at org.openj9.test.attachAPI.AttachApiTest.logExceptionInfoAndFail(AttachApiTest.java:62)
at org.openj9.test.attachAPI.TestAttachErrorHandling.connectAndVerifyConnection(TestAttachErrorHandling.java:413)
at org.openj9.test.attachAPI.TestAttachErrorHandling.testPrematureSocketClose(TestAttachErrorHandling.java:287)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:124)
at org.testng.internal.Invoker.invokeMethod(Invoker.java:580)
at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:716)
at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:988)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:125)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109)
at org.testng.TestRunner.privateRun(TestRunner.java:648)
at org.testng.TestRunner.run(TestRunner.java:505)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:455)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:450)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:415)
at org.testng.SuiteRunner.run(SuiteRunner.java:364)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:84)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1208)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1137)
at org.testng.TestNG.runSuites(TestNG.java:1049)
at org.testng.TestNG.run(TestNG.java:1017)
at org.testng.TestNG.privateMain(TestNG.java:1354)
at org.testng.TestNG.main(TestNG.java:1323)

It doesn't seem like something that's related to the issue being fixed here.
@ymanton what's your opinion on this?

[pshipton]

The failures are all known problems, not related to this PR.

[mpirvu]

In this case, this commit is ready to merged.