Update spec & makefile scripts for RISC-V in OpenJ9 (part1/spec) #7440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already verified the compilation on Fedora_Linux/QEMU. Reviewer: @keithc-ca , @pshipton , @DanHeidinga |
ChengJin01
force-pushed
the
riscv_openj9_part1_spec_mk
branch
from
11e6fa4
to
55b3d35
Compare
keithc-ca
reviewed
Nov 11, 2019
ChengJin01
force-pushed
the
riscv_openj9_part1_spec_mk
branch
from
55b3d35
to
430fa45
Compare
|
Do we need/want the equivalent changes for cmake? |
The whole changes are based on UMA. We are not doing cmake for the moment. |
|
An issue at #7833 has been created to keep track of the warnings to be addressed in the future. |
|
And another issue at #7834 for |
keithc-ca
reviewed
Nov 22, 2019
ChengJin01
force-pushed
the
riscv_openj9_part1_spec_mk
branch
from
430fa45
to
87b11ff
Compare
ChengJin01
force-pushed
the
riscv_openj9_part1_spec_mk
branch
from
87b11ff
to
6679f28
Compare
keithc-ca
requested changes
Dec 10, 2019
The changes mainly include SPEC & makefile scripts in the spec and makelib directories to enable RISC-V 64bit from the OpenJ9 perspective. Issue: eclipse#7421 Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
ChengJin01
force-pushed
the
riscv_openj9_part1_spec_mk
branch
from
6679f28
to
a4a8df0
Compare
keithc-ca
approved these changes
Dec 10, 2019
|
We have no PR builds for RISC-V; as the successful travis build attests, this should not affect other platforms - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes mainly include SPEC & makefile scripts
in the spec and makelib directories to enable
RISC-V 64bit from the OpenJ9 perspective.
Issue: eclipse#7421
Signed-off-by: Cheng Jin jincheng@ca.ibm.com