Add missing barriers to jProfiling helpers #7964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the tryLock and unlock methods on the jProfiling hash table implementation did not contain any read or write barriers. While this is fine on architectures such as x86-64, this causes problems with the weak memory model used in Power. Failing to include the barriers could allow reordering of memory accesses to cause incorrect behaviour with unpredictable results. Signed-off-by: Ben Thomas <ben@benthomas.ca>
andrewcraik
approved these changes
Dec 5, 2019
|
Jenkins test sanity all jdk8,jdk11 |
|
Jenkins test sanity osx jdk11 |
|
Sanity full passed merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the tryLock and unlock methods on the jProfiling hash table
implementation did not contain any read or write barriers. While this is
fine on architectures such as x86-64, this causes problems with the weak
memory model used in Power. Failing to include the barriers could allow
reordering of memory accesses to cause incorrect behaviour with
unpredictable results.
Signed-off-by: Ben Thomas ben@benthomas.ca