Pass correct prefix length to removeCacheVersionAndGen() #7987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Dec 6, 2019
|
What was broken by this problem? |
Non-persistent cache was not able to figure out the correct cache name (for a lower layer) from a cache unique ID. |
Please include that information in the commit comment. |
Done. |
Persistent cache and non-persistent cache have different prefixes, pass the correct prefix length to removeCacheVersionAndGen(), so that Non-persistent cache is able to figure out the correct cache name (for a lower layer) from a cache unique ID. Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
|
jenkins test sanity plinux jdk8 |
|
jenkins test sanity win jdk8 |
pshipton
approved these changes
Dec 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Persistent cache and non-persistent cache have different prefixes, pass
the correct prefix length to removeCacheVersionAndGen(), so that
Non-persistent cache is able to figure out the correct cache name (for a
lower layer) from a cache unique ID.
Signed-off-by: Hang Shao hangshao@ca.ibm.com