Define OPENJ9_BUILD for JIT when similarly named env var is set #8668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JIT code looks at the following macro: `J9_SHARED_CACHE_DEFAULT_BOOT_SHARING(vm)` which in turn depends on `OPENJ9_BUILD` being defined. VM makefiles define `OPENJ9_BUILD` based on a similarly named environment variable: ifeq ($(OPENJ9_BUILD),true) CFLAGS+=-DOPENJ9_BUILD CXXFLAGS+=-DOPENJ9_BUILD CPPFLAGS+=-DOPENJ9_BUILD endif However, this define does not apply to the JIT code. This commit rectifies the situation by changing the JIT makefiles to inspect OPENJ9_BUILD environment variable and to set the `OPENJ9_BUILD` define accordingly. Closes: eclipse-openj9#8660 Signed-off-by: Marius Pirvu <mpirvu@ca.ibm.com>
|
Do we need to define this in the CMakeLists.txt for the compiler [1] or will we picked them up from the VM? @dnakamura FYI. [1] https://github.com/eclipse/openj9/blob/master/runtime/compiler/CMakeLists.txt |
|
@fjeremic Looks like the compiler is inheriting it properly from the vm |
fjeremic
approved these changes
Feb 26, 2020
|
Jenkins test sanity all jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JIT code looks at the following macro:
J9_SHARED_CACHE_DEFAULT_BOOT_SHARING(vm)which in turn depends on
OPENJ9_BUILDbeing defined.VM makefiles define
OPENJ9_BUILDbased on a similarly namedenvironment variable:
ifeq ($(OPENJ9_BUILD),true)
CFLAGS+=-DOPENJ9_BUILD
CXXFLAGS+=-DOPENJ9_BUILD
CPPFLAGS+=-DOPENJ9_BUILD
endif
However, this define does not apply to the JIT code.
This commit rectifies the situation by changing the JIT makefiles
to inspect OPENJ9_BUILD environment variable and to set the
OPENJ9_BUILD define accordingly.
Closes: #8660
Signed-off-by: Marius Pirvu mpirvu@ca.ibm.com