AArch64: Disable j9sysinfo_test_get_levels_and_types() #8711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related PR: #8617 |
0xdaryl
reviewed
Mar 2, 2020
runtime/tests/port/si.c
Outdated
| @@ -2273,7 +2273,7 @@ j9sysinfo_runTests(struct J9PortLibrary *portLibrary, char *argv0) | |||
| rc |= j9sysinfo_test_get_groups(portLibrary); | |||
| #endif /* !(defined(WIN32) || defined(WIN64)) */ | |||
| rc |= j9sysinfo_test_get_l1dcache_line_size(portLibrary); | |||
| #if !(defined(LINUXPPC) || defined(S390) || defined(J9ZOS390) || defined(J9ARM) || defined(OSX)) | |||
| #if !(defined(LINUXPPC) || defined(S390) || defined(J9ZOS390) || defined(J9ARM) || defined(J9AARCH64) || defined(OSX)) | |||
| rc |= j9sysinfo_test_get_levels_and_types(portLibrary); | |||
| #endif /* !(defined(LINUXPPC) || defined(S390) || defined(J9ZOS390) || defined(J9ARM) || defined(OSX)) */ | |||
There was a problem hiding this comment.
You should update this closing comment as well.
There was a problem hiding this comment.
Updated the comment part.
|
Is there an issue for tracking re-enabling this test? |
This commit disables running j9sysinfo_test_get_levels_and_types() on AArch64. Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
|
@DanHeidinga I opened #8723 for tracking. |
|
jenkins test sanity alinux64 jdk11 |
|
I would like this PR to be merged if it is OK. |
|
@DanHeidinga : any objections if we merge this? |
My concern about the reminder issue has been addressed so I don't object (though I haven't reviewed the code) |
DanHeidinga
approved these changes
Mar 12, 2020
0xdaryl
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit disables running j9sysinfo_test_get_levels_and_types()
on AArch64.
Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com