Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64: Implement Nestmate interface call #8651

Merged
merged 1 commit into from
Mar 13, 2020
Merged

AArch64: Implement Nestmate interface call #8651

merged 1 commit into from
Mar 13, 2020

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Feb 25, 2020

This commit implements Nestmate interface call for AArch64.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k knn-k mentioned this pull request Feb 25, 2020
Closed
@knn-k
Copy link
Contributor Author

knn-k commented Mar 3, 2020

Based on the implementation for Power in #2809.

@knn-k
Copy link
Contributor Author

knn-k commented Mar 3, 2020

jenkins test sanity alinux64 jdk11

@knn-k knn-k changed the title WIP: AArch64: Implement Nestmate interface call AArch64: Implement Nestmate interface call Mar 3, 2020
@knn-k
Copy link
Contributor Author

knn-k commented Mar 3, 2020

This change fixes the failures with Nestmate_virtual_private_2 and Nestmate_virtual_private_3.
The test result is as expected.

@knn-k
Copy link
Contributor Author

knn-k commented Mar 4, 2020

jenkins test sanity.system alinux64 jdk11

This was referenced Mar 4, 2020
Merged
Merged
0xdaryl
0xdaryl reviewed Mar 11, 2020
View reviewed changes
runtime/compiler/aarch64/runtime/PicBuilder.spp Outdated
.set J9TR_ICSnippet_Class1, 40
.set J9TR_ICSnippet_TargetAddr1, 48
.set J9TR_ICSnippet_Class2, 56
.set J9TR_ICSnippet_TargetAddr1, 64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already defined on L114. Should be J9TR_ICSnippet_TargetAddr2?

runtime/compiler/aarch64/codegen/CallSnippet.cpp Outdated
*(intptrj_t *)cursor = -1;
*(intptrj_t *)(cursor+sizeof(intptrj_t)) = (intptrj_t)blAddress;
*(intptrj_t *)(cursor+2*sizeof(intptrj_t)) = -1;
*(intptrj_t *)(cursor+3*sizeof(intptrj_t)) = (intptrj_t)blAddress;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of these fields? Are they for building an interface PIC? If I understand the code in this PR correctly, they are introduced but not used in this PR. I would say your commit message should at least comment on the fact that you're introducing them here, but the actual PIC mechanics will be completed later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the code removing the unused snippet fields.

@knn-k
Copy link
Contributor Author

knn-k commented Mar 12, 2020

jenkins test sanity alinux64 jdk11

@knn-k
Copy link
Contributor Author

knn-k commented Mar 12, 2020

Test result is as expected:

[2020-03-12T03:40:28.334Z] FAILED test targets:
[2020-03-12T03:40:28.334Z] 	cmdLineTester_pltest_0
[2020-03-12T03:40:28.334Z] 
[2020-03-12T03:40:28.334Z] TOTAL: 287   EXECUTED: 151   PASSED: 150   FAILED: 1   DISABLED: 6   SKIPPED: 130

Two Nestmate_virtual_private_* tests passed by applying this PR.
The failure with cmdLineTester_pltest_0 is addressed by #8617 and #8711.

@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 12, 2020

This will require a rebase now please.

@knn-k
AArch64: Implement Nestmate interface call
f9cbb00 
This commit implements Nestmate interface call for AArch64.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k
Copy link
Contributor Author

knn-k commented Mar 12, 2020

jenkins test sanity alinux64 jdk11

@knn-k
Copy link
Contributor Author

knn-k commented Mar 12, 2020

Rebased, and also updated my code rewriting intptrj_t to intptr_t (#8835).

@knn-k
Copy link
Contributor Author

knn-k commented Mar 13, 2020

The test result after rebase is the same as yesterday's result: Only cmdLineTester_pltest_0 fails in sanity.functional.

@0xdaryl 0xdaryl merged commit 5e635ee into eclipse-openj9:master Mar 13, 2020
@0xdaryl
Copy link
Contributor

0xdaryl commented Mar 13, 2020

This will need a PR for the 0.20.0 release as well please.

@knn-k knn-k deleted the aarch64nestmate2 branch March 13, 2020 03:10
@knn-k knn-k mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xdaryl 0xdaryl 0xdaryl approved these changes

Assignees
No one assigned
Labels
arch:aarch64 comp:jit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @0xdaryl