Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change realTimeGC option as per compilation #8895

Merged
merged 1 commit into from Mar 23, 2020
Merged

Change realTimeGC option as per compilation #8895

merged 1 commit into from Mar 23, 2020

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Mar 17, 2020

This change is to support the JITServer receiving the realTimeGC config setting from the client for per compilation.

Also implemented the server version of getCellSizeForSizeClass() and getObjectSizeClass() which were missing and are triggered when realTimeGC is true.

Related to eclipse/omr#4945

Fixes: #8707

Signed-off-by: Annabelle Huo Annabelle.Huo@ibm.com

mpirvu
mpirvu reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments that need to be addressed

runtime/compiler/arm/codegen/J9ARMEvaluator.cpp Outdated Show resolved Hide resolved
runtime/compiler/env/VMJ9.cpp Show resolved Hide resolved
runtime/compiler/p/codegen/J9PPCSnippet.cpp Outdated Show resolved Hide resolved
runtime/compiler/p/codegen/J9PPCSnippet.cpp Outdated Show resolved Hide resolved
runtime/compiler/z/codegen/J9TreeEvaluator.cpp Outdated Show resolved Hide resolved
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Mar 18, 2020
@mpirvu mpirvu added this to In progress in JIT as a Service via automation Mar 18, 2020
mpirvu
mpirvu reviewed Mar 18, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to leave the implementation of TR_J9VMBase::initializeLocalObjectFlags to another PR because it needs more thought. Also, this frentend method is not called for RealTime which is the focus of this PR

runtime/compiler/env/VMJ9Server.cpp Outdated Show resolved Hide resolved
@a7ehuo a7ehuo changed the title WIP: Change realTimeGC option as per compilation Change realTimeGC option as per compilation Mar 19, 2020
@a7ehuo a7ehuo marked this pull request as ready for review March 19, 2020 19:20
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Mar 19, 2020

@mpirvu VM_initializeLocalObjectFlags message is removed. All comments addressed. Ready for another review. Thanks.

mpirvu
mpirvu approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpirvu
Copy link
Contributor

mpirvu commented Mar 19, 2020

Please rebase to eliminate conflits

@mpirvu mpirvu self-assigned this Mar 19, 2020
@a7ehuo a7ehuo force-pushed the fixRealTimeGC-2 branch 2 times, most recently from 80f7721 to d402a2a Compare March 19, 2020 21:03
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Mar 19, 2020

@mpirvu Rebased, ready for another review. Thanks.

@mpirvu
Copy link
Contributor

mpirvu commented Mar 20, 2020

jenkins compile xlinuxcm jdk11

mpirvu
mpirvu approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a7ehuo
Copy link
Contributor Author

a7ehuo commented Mar 20, 2020

CI failed. Looks like a infrastructure issue.
@mpirvu Could a sanity test be run besides of compiling the build? Thanks.

checking that freemarker location is set... no
737
738The FreeMarker library is required to build the OpenJ9 build tools
739and has to be provided during configure process.
740
741Download the FreeMarker library and unpack it into an arbitrary directory:
742
743wget https://sourceforge.net/projects/freemarker/files/freemarker/2.3.8/freemarker-2.3.8.tar.gz/download -O freemarker-2.3.8.tar.gz
744
745tar -xzf freemarker-2.3.8.tar.gz
746
747Then run configure with '--with-freemarker-jar=<freemarker_jar>'
748
749configure: error: Cannot continue
750configure exiting with result code 1
751The command "bash ./buildenv/travis/build-on-travis.sh" exited with 1.
cache.2
752store build cache

@a7ehuo
Change realTimeGC option as per compilation
0217286 
This change is to support the JITServer receiving
the realTimeGC config setting from the client for
per compilation.

Also implemented the server version of
`getCellSizeForSizeClass() and `getObjectSizeClass()`
which were missing and are triggered when realTimeGC is true.

Related to eclipse/omr#4945

Fixes: eclipse-openj9#8707

Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@mpirvu
Copy link
Contributor

mpirvu commented Mar 20, 2020

jenkins test sanity plinuxjit,xlinuxjit jdk8,jdk11

@mpirvu
Copy link
Contributor

mpirvu commented Mar 20, 2020

xlinux Java8 had a failure that we've seen before:

Testing: Test StringBuffer/StringBuilder growth
Test start time: 2020/03/20 14:46:16 Atlantic Standard Time
Running command: "/home/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_linux_jit_Personal/openjdkbinary/j2sdk-image/bin/java" -XX:+UseJITServer -Xcompressedrefs  -Xdump -Xdump:none -Xmx7g -Djava.lang.stringBuffer.growAggressively -cp "/home/jenkins/workspace/Test_openjdk8_j9_sanity.functional_x86-64_linux_jit_Personal/openjdk-tests/TKG/../../jvmtest/functional/cmdLineTests/cmdLineTest_J9tests/cmdLineTest_J9tests.jar" TestStringBufferAndBuilderGrowth
Time spent starting: 2 milliseconds
Time spent executing: 12139 milliseconds
Test result: FAILED
Output from test:
 [OUT] Machine has physical memory 25282244608 bytes or 24111 MB or 23 GB
 [ERR] JITServer is currently a technology preview. Its use is not yet supported
>> Success condition was not found: [Output match: StringBuffer capacity=2147483647 StringBuilder capacity=2147483647]
>> Success condition was not found: [Output match: Option too large]
>> Success condition was not found: [Output match: Not enough resource to run test]
>> Success condition was not found: [Output match: Failed to instantiate heap]

@mpirvu
Copy link
Contributor

mpirvu commented Mar 23, 2020

This item is ready to be delivered

@mpirvu mpirvu merged commit cbd77bf into eclipse-openj9:master Mar 23, 2020
JIT as a Service automation moved this from In progress to Done Mar 23, 2020
@a7ehuo a7ehuo deleted the fixRealTimeGC-2 branch May 1, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpirvu mpirvu mpirvu approved these changes

Assignees

@mpirvu mpirvu

Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
JIT as a Service
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JDK8 JITServer : ClassLoadingTest_special_12_FAILED
2 participants
@a7ehuo @mpirvu