Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop setting OMR_GC_COMPRESSED_POINTERS #8905

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Stop setting OMR_GC_COMPRESSED_POINTERS #8905

merged 1 commit into from
Mar 19, 2020

Conversation

youngar
Copy link
Contributor

@youngar youngar commented Mar 18, 2020 •
edited
Loading

This option was deprecated, and is no longer used in the autoconf
builds. Remove the flag J9VM_GC_COMPRESSED_POINTERS as it appears to
be entirely unused, and only exists in the cmake build system.
cc @gacholio @dnakamura

@gacholio
Copy link
Contributor

@keithc-ca Will this cause issues with DDR?

keithc-ca
keithc-ca reviewed Mar 18, 2020
View reviewed changes
runtime/ddr/overrides-vm Outdated Show resolved Hide resolved
@youngar youngar changed the title Stop setting OMR_GC_COMPRESSED_POINTERS WIP: Stop setting OMR_GC_COMPRESSED_POINTERS Mar 18, 2020
@youngar
Copy link
Contributor Author

youngar commented Mar 18, 2020

Marking as WIP until I figure out the correct change for DDR :)

@youngar
Stop setting OMR_GC_COMPRESSED_POINTERS
d67af3f 
This option was deprecated, and is no longer used in the autoconf
builds.

Signed-off-by: Andrew Young <youngar17@gmail.com>
@youngar
Copy link
Contributor Author

youngar commented Mar 18, 2020 •
edited
Loading

I'm leaving the flag J9VM_GC_COMPRESSED_POINTERS alone. Although we don't use this flag in code, it is used by DDR. Thanks for the help @keithc-ca.

@youngar youngar changed the title WIP: Stop setting OMR_GC_COMPRESSED_POINTERS Stop setting OMR_GC_COMPRESSED_POINTERS Mar 18, 2020
@youngar
Copy link
Contributor Author

youngar commented Mar 19, 2020

@gacholio this is good to go now

@gacholio
Copy link
Contributor

CI build tested cmake.

@gacholio gacholio merged commit 05af7d8 into eclipse-openj9:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youngar @gacholio @keithc-ca