AArch64: Implement genHeapAlloc for VMnewEvaluator #9607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira1Saitoh
force-pushed
the
aarch64GenHeapAlloc
branch
from
8792fb0
to
e28e0f2
Compare
Akira1Saitoh
force-pushed
the
aarch64GenHeapAlloc
branch
from
e28e0f2
to
0a3f6c4
Compare
|
jenkins compile alinux64 jdk11 |
Akira1Saitoh
changed the title
knn-k
reviewed
May 21, 2020
| @@ -564,7 +564,74 @@ static void | |||
| genHeapAlloc(TR::Node *node, TR::CodeGenerator *cg, uint32_t allocSize, TR::Register *resultReg, TR::Register *heapTopReg, | |||
| TR::Register *tempReg, TR::LabelSymbol *callLabel) | |||
| { | |||
| TR_UNIMPLEMENTED(); | |||
| TR::Compilation * comp = cg->comp(); | |||
| TR_J9VMBase *fej9 = (TR_J9VMBase *) (cg->fe()); | |||
There was a problem hiding this comment.
fej9 is used nowhere in this function.
knn-k
reviewed
May 21, 2020
| TR::Compilation * comp = cg->comp(); | ||
| TR_J9VMBase *fej9 = (TR_J9VMBase *) (cg->fe()); | ||
| TR::Register *metaReg = cg->getMethodMetaDataRegister(); | ||
| TR::ILOpCodes opCode = node->getOpCodeValue(); |
There was a problem hiding this comment.
opCode is used nowhere in this function.
knn-k
reviewed
May 21, 2020
| @@ -564,7 +564,74 @@ static void | |||
| genHeapAlloc(TR::Node *node, TR::CodeGenerator *cg, uint32_t allocSize, TR::Register *resultReg, TR::Register *heapTopReg, | |||
| TR::Register *tempReg, TR::LabelSymbol *callLabel) | |||
| { | |||
| TR_UNIMPLEMENTED(); | |||
| TR::Compilation * comp = cg->comp(); | |||
There was a problem hiding this comment.
comp is used nowhere in this function.
Implement `genHeapAlloc` helper method used by `VMnewEvaluator`. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64GenHeapAlloc
branch
from
0a3f6c4
to
e7fb217
Compare
|
Removed 3 unused variables mentioned above. |
|
jenkins compile alinux64 jdk11 |
knn-k
approved these changes
May 21, 2020
|
Build was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
genHeapAllochelper method used byVMnewEvaluator.Depends on #9605
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com