AArch64: Enable inlining of jitNewObject #9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akira1Saitoh
force-pushed
the
aarch64NewObject
branch
from
795587c
to
0352f58
Compare
Akira1Saitoh
force-pushed
the
aarch64NewObject
branch
from
0352f58
to
609ec78
Compare
knn-k
reviewed
May 21, 2020
| TR::Node::recreate(node, TR::acall); | ||
| TR::Register *targetRegister = directCallEvaluator(node, cg); | ||
| TR::Node::recreate(node, opCode); | ||
| TR::Compilation *comp = cg->comp(); |
There was a problem hiding this comment.
comp is used nowhere in this function.
There was a problem hiding this comment.
Removed unused comp.
This commit enables inlining of `jitNewObject`. Signed-off-by: Akira Saitoh <saiaki@jp.ibm.com>
Akira1Saitoh
force-pushed
the
aarch64NewObject
branch
from
609ec78
to
ae0c784
Compare
|
jenkins test sanity alinux64 jdk11 |
|
jenkins test extended.functional alinux64 jdk11 |
|
The failure with |
Akira1Saitoh
changed the title
knn-k
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables inlining of
jitNewObject.The limitation of the current implementation is:
TR::newonly.DualTLH.Inlining under AOT compilation is not enabled yet.
Depends on:
Signed-off-by: Akira Saitoh saiaki@jp.ibm.com