Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old cpu.is() and cpu.isAtLeast() #9647

Merged
merged 1 commit into from
May 23, 2020

Conversation

harryyu1994
Copy link
Contributor

Signed-off-by: Harry Yu harryyu1994@gmail.com

Signed-off-by: Harry Yu <harryyu1994@gmail.com>
@harryyu1994
Copy link
Contributor Author

@mpirvu Hi Marius, could you help review and merge this change?

The purpose of this change is so that we don't break OpenJ9 when the OMR side change (Replace CPU API on x86) goes in.

The old api's, isAtLeast() as an example, is going to get removed in the OMR change. So I'm going to remove its usages here in OpenJ9 first.

This change does not change the semantics of the code.

@harryyu1994
Copy link
Contributor Author

@fjeremic Hey Filip, could you help review this one? Once this is merged, eclipse/omr#5151 is ready for final review and merge.

@fjeremic fjeremic self-assigned this May 22, 2020
@fjeremic
Copy link
Contributor

Jenkins test sanity all jdk8

@fjeremic fjeremic merged commit 66c3218 into eclipse-openj9:master May 23, 2020
@harryyu1994 harryyu1994 deleted the removeOldAtLeast branch May 27, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants