Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close timing hole in System.exit #9885

Merged
merged 1 commit into from Jun 16, 2020
Merged

Conversation

gacholio
Copy link
Contributor

#9867 introduced a very small window where user daemon threads would
illegally be allowed to call System.exit while the VM is being
destroyed.

[ci skip]

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

runtime/vm/jvminit.c Outdated Show resolved Hide resolved
runtime/vm/jvminit.c Outdated Show resolved Hide resolved
illegally be allowed to call System.exit while the VM is being
destroyed.

[ci skip]

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk11

@DanHeidinga DanHeidinga self-assigned this Jun 16, 2020
@DanHeidinga DanHeidinga merged commit ac6141a into eclipse-openj9:master Jun 16, 2020
@DanHeidinga
Copy link
Member

@gacholio can you open the PR for this against the 0.21 branch as well given this is targeted to that release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants