Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative VM paths in AUT.ini on MacOS #75

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

basilevs
Copy link
Contributor

@basilevs basilevs commented May 3, 2024

Ignore AUT configuration if Runner is explicitly given a VM in command line. This changes the semantics of -autVM argument - now it takes priority over AUT's configuration.
Resolve VM paths relative to configuration file location.

Before this change, Runner logged errors even if JVM was configured via command line:

Trying to use VM from application's ini file: ../Eclipse/features/net.openchrom.jre.macosx.cocoa.aarch64.feature_17.0.11/jre/jdk-17.0.11+9-jre/Contents/Home/lib/libjli.dylib
/private/tmp/Eclipse.app/../Eclipse/features/net.openchrom.jre.macosx.cocoa.aarch64.feature_17.0.11/jre/jdk-17.0.11+9-jre/Contents/Home/lib/libjli.dylibdoes not exist
AUT-0: Launch failed. Reason: FAIL: AUT requires aarch64 Java VM which cannot be found.
Please specify -autVM {javaPath} command line argument to use different JVM.

Related bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=515501

…cosx.cocoa.aarch64.feature_17.0.11/jre/jdk-17.0.11+9-jre/Contents/Home/lib/libjli.dylibdoes

not exist

Ignore AUT configuration if Runner is explicitly given a VM in command
line.
Resolve VM paths relative to configuration file location.
@basilevs basilevs merged commit 030e4ed into master May 7, 2024
1 of 2 checks passed
@basilevs basilevs deleted the fixAutsJre branch May 7, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant