Add support for selecting/enforcing a TLS version #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion' field in the MQTTClient_SSLOptions structure. This affects which *_client_method() function is called in SSLSocket.c: 0 (default) -> SSLv23_client_method(), 1 -> TLSv1_client_method(), 2 -> TLSv1_1_client_method(), 3 -> TLSv1_2_client_method()
…rsion' field in the MQTTClient_SSLOptions structure. This affects which *_client_method() function is called in SSLSocket.c: 0 (default) -> SSLv23_client_method(), 1 -> TLSv1_client_method(), 2 -> TLSv1_1_client_method(), 3 -> TLSv1_2_client_method() Signed-off-by: Günter Obiltschnig <guenter.obiltschnig@appinf.com>
…hub.com/obiltschnig/paho.mqtt.c into feature/ssl-allow-tls-version-selection
obiltschnig
changed the title
Closed
|
Fixes #332. |
|
Hello. Thanks for this PR. For me to merge it, the IP issue will have to be fixed: "The following users have invalid Signed-off-by footers. Please use the Signed-Off-By (git commit -s) mechanism to confirm the origin of the submission. The identity in the Signed-off-By must match the Author or the Committer. |
|
Created a new pull request: #333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for selecting/enforcing a TLS version through a new
sslVersionfield in theMQTTClient_SSLOptionsstruct. This affects which*_client_method()function is called in SSLSocket.c:MQTT_SSL_VERSION_DEFAULT) ->SSLv23_client_method()MQTT_SSL_VERSION_TLS_1_0) ->TLSv1_client_method()MQTT_SSL_VERSION_TLS_1_1) ->TLSv1_1_client_method()MQTT_SSL_VERSION_TLS_1_2) ->TLSv1_2_client_method()We use this in macchina.io.