cmake/FindMahoMqttC.cmake: fix static build #275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static libraries of paho-mqtt-c are not suffixed with -static since version 1.3.2 and eclipse/paho.mqtt.c@8cc51c7 See: eclipse/paho.mqtt.c#704 Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
|
Oh, wow. I forgot this was here. Apologies! I'll pull this in, but I think it fixed the *nix build and breaks the Windows build. Either way, thanks for the contribution. We're going to start looking at CMake and the build systems soon, so any comments and suggestions welcome. |
fpagliughi
added a commit
that referenced
this pull request
Dec 13, 2020
|
Thanks again for the contribution, but this did break the Windows build. The block needs to stay in the file, but in an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static libraries of paho-mqtt-c are not suffixed with -static since version 1.3.2 and eclipse/paho.mqtt.c@8cc51c7
See: eclipse/paho.mqtt.c#704
Signed-off-by: Fabrice Fontaine fontaine.fabrice@gmail.com