You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found that most embedded projects do not have folder-separated include files (e.g. STMicro's BSP, ARM's CMSIS all expect single-level includes and a properly defined INCLUDE path).
That said, because the name is generic (i.e. does not include "Paho"), I see how name collisions could appear. I never tried it but attempting to install the build on Linux side-by-side with Paho Linux will likely cause issues.
My preference is towards paho-embedded/ or similar to disambiguate from the paho.mqtt.c's "MQTTClient.h". We could also change the name of the client to include "Paho" or "PahoEmbedded" although I find that a bigger breaking change.
Hello,
The current code requies includes like
#include <MQTTClient.h>
, which can lead to a mess if you happen to have multiple mqtt-related dependencies.How about prefixing the includes with something like
paho/
orpaho-embedded/
?I'm willing to prepare a PR for this if the maintainers agree (and if this repo isn't as abandoned as it looks).
The text was updated successfully, but these errors were encountered: