Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move includes to a subdirectory #236

Closed
Equidamoid opened this issue Jun 27, 2022 · 3 comments
Closed

Move includes to a subdirectory #236

Equidamoid opened this issue Jun 27, 2022 · 3 comments

Comments

@Equidamoid
Copy link

Hello,

The current code requies includes like #include <MQTTClient.h>, which can lead to a mess if you happen to have multiple mqtt-related dependencies.

How about prefixing the includes with something like paho/ or paho-embedded/?

I'm willing to prepare a PR for this if the maintainers agree (and if this repo isn't as abandoned as it looks).

@CIPop
Copy link

CIPop commented Jul 18, 2023

I found that most embedded projects do not have folder-separated include files (e.g. STMicro's BSP, ARM's CMSIS all expect single-level includes and a properly defined INCLUDE path).
That said, because the name is generic (i.e. does not include "Paho"), I see how name collisions could appear. I never tried it but attempting to install the build on Linux side-by-side with Paho Linux will likely cause issues.

My preference is towards paho-embedded/ or similar to disambiguate from the paho.mqtt.c's "MQTTClient.h". We could also change the name of the client to include "Paho" or "PahoEmbedded" although I find that a bigger breaking change.

@CIPop
Copy link

CIPop commented Jul 19, 2023

Similar / duplicate to #156.

@icraggs
Copy link
Contributor

icraggs commented Nov 29, 2023

Close as duplicate of #156

@icraggs icraggs closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants