Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from PR#554 on gradle #607

Closed
desokroshan opened this issue Jan 3, 2019 · 12 comments
Closed

Changes from PR#554 on gradle #607

desokroshan opened this issue Jan 3, 2019 · 12 comments
Assignees
Milestone

Comments

@desokroshan
Copy link
Contributor

desokroshan commented Jan 3, 2019

Please fill out the form below before submitting, thank you!

  • [*] Bug exists Release Version 1.2.0 ( Master Branch)
  • [*] Bug exists in MQTTv3 Client on Snapshot Version 1.2.1-SNAPSHOT (Develop Branch)
  • [*] Bug exists in MQTTv5 Client on Snapshot Version 1.2.1-SNAPSHOT (Develop Branch)

@icraggs I want to be able to consume the changes that were merged as part of PR#554 through gradle on Android Studio. Is there a plan to release these changes anytime soon?

If this is a bug regarding the Android Service, please raise the bug here instead: https://github.com/eclipse/paho.mqtt.android/issues/new

@icraggs
Copy link
Collaborator

icraggs commented Jan 9, 2019

I'm working on the 1.3 release (https://github.com/eclipse/paho.mqtt.java/milestone/2) which will incorporate these changes. I hope to have this done by the end of January.

You could use the develop branch in the meantime - most of my changes will be on the MQTT V5 client.

@desokroshan
Copy link
Contributor Author

desokroshan commented Jan 10, 2019

Great, thanks. Just for the context, I am working on adding custom authorizer support in aws-sdk-android. Since the SDK uses paho java client, we need custom header support in paho(Changes in PR#554) to be able to release the changes to our customers.
I have been working off of the develop branch and would like to point out an additional blocker to our release. The develop branch has the required custom header support but additionally also has a known issue in connecting to AWS IoT Broker. See #345 for details. So even though the 1.3 release would have custom header support, we cannot really use it and release our changes. Currently we are using paho version 1.1.0 and have not been able to update our dependency to the latest version because of #345. I assume the fix for this is not planned for 1.3 release as I don't see it in the list of issues milestone addresses. It would be great to have it as part of the release since there has been quite a few customer requests for custom authorization support in the SDK. If it would not be possible to include it in this release can you share some tentative timeline on when we can have these changes?

@mutablealligator
Copy link

@icraggs I do not see the fix for custom authorization headers in the milestone for 1.3.0 (https://github.com/eclipse/paho.mqtt.java/milestone/2). Will this change be included in 1.3.0?

@frankmuellr
Copy link

Hi @icraggs,

Is there an ETA for when custom authorization headers support will be released? We have several customers requesting the feature. Please let us know if there's anything we can do to help.

@icraggs
Copy link
Collaborator

icraggs commented Feb 18, 2019

I'm happy to include a fix for the issue of 'custom authorisation headers'. From reading the issues and PR, I think that the fix is already in the develop branch. Does anyone want to confirm or deny that assumption?

Everything in the develop branch will be included in the next release. I'm hoping to make a 1.2.1 service release with all the fixes included so far, as I'm refactoring the MQTT V5 client lib.

@desokroshan
Copy link
Contributor Author

desokroshan commented Feb 18, 2019

Yes, I can confirm that the changes to support 'Custom authorization headers' are already in develop branch(Relevant Commit). A service release would be great for our purpose.

@icraggs
Copy link
Collaborator

icraggs commented Feb 20, 2019

I'm trying to create a 1.2.1 release with all the fixes in the develop branch. At the moment I'm dealing with an issue in the Eclipse infrastructure which is stopping the jars from being signed. I hope this will be resolved in the next day or so.

@desokroshan
Copy link
Contributor Author

Thanks for the update.

@icraggs icraggs added this to the 1.2.1 milestone Feb 20, 2019
@icraggs icraggs self-assigned this Feb 20, 2019
@icraggs
Copy link
Collaborator

icraggs commented Feb 21, 2019

1.2.1 released. Should be in all repos.

@icraggs icraggs closed this as completed Feb 21, 2019
@mutablealligator
Copy link

Thank you @icraggs !

@frankmuellr
Copy link

@icraggs - The release is not listed here btw: https://github.com/eclipse/paho.mqtt.java/releases

@icraggs
Copy link
Collaborator

icraggs commented Feb 21, 2019

@muellerfr I was waiting a couple of days to make sure I hadn't messed anything up... I'll probably tag it on the weekend. The jars are in the maven/nexus repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants