Added custom headers support for WebSocket connection (502) #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii <vitalii.vlasiuk@temy.co>
1 task
davidgraeff
reviewed
Jun 18, 2018
| @@ -39,6 +39,7 @@ | |||
| private String uri; | |||
| private String host; | |||
| private int port; | |||
| private Properties customWebSocketHeaders; | |||
There was a problem hiding this comment.
And why is it a Properties field now, instead of a Map? Properties is deprecated and the reading/writing abilities of Properties are not used in this case? Can I issue a PR to change this to Map please?
There was a problem hiding this comment.
Properties is used for sslClientProps.
Sure, Map is better.
New pull request - #555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Vlasiuk vvlasuk@gmail.com
#502
Minor fix that allow use custom headers in request using WebSockets :
Added new parameter "customHeaders" to MqttConnectOptions
Pass this param to WebSocketHandshake
Added new custom headers to handshake request
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!