Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor NetworkModule creation; support custom protocols/schemes #489

Closed
wants to merge 1 commit into from

Conversation

Bisk1
Copy link
Contributor

@Bisk1 Bisk1 commented Feb 21, 2018

  • You have signed the Eclipse ECA
  • All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
  • If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.'
    Implements Add option to use custom protocols and schemas #486
    Creating network modules is now split into protocol-specific classes
    Custom protocol-specific implementations can be added
    Removed dead code

Simplify the module by splitting into class hierarchy
Support custom protocols/schemes

Signed-off-by: Daniel Dylag <bisker@op.pl>
@mscheibler
Copy link

My PullRequest Network module SPI is basically the same topic. It would allow to add custom protocols/schemes by implementing them as Java SPI and adding them to the classpath.
Maybe we could join our efforts

@Bisk1
Copy link
Contributor Author

Bisk1 commented Jun 13, 2018

@mscheibler very well, I haven't seen your PR. Closing mine then.

@Bisk1 Bisk1 closed this Jun 13, 2018
@mscheibler
Copy link

I hope that mine PR gets merged in the foreseeable future. I updated it a few times already, but after the initial contect there was no resopse from the project owner. Maybe another voice could help.

@Bisk1 Bisk1 deleted the refactor-protocol-set branch February 3, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants