Update documentation/comments for connect() ref blocking
#615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n returns. As per discussion in issue eclipse#521
|
Sure would be neat if this got merged! |
PierreF
approved these changes
Dec 22, 2023
|
Thank for you contribution and your patience. This PR is now merged. |
This was referenced Dec 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update documentation/comments to clarify when the
connect()function returns. The function returns after transmitting theCONNECTpacket but before theCONNACKis received/processed (this is done in the network loop). There are a number of issues (both on github and stack overflow) caused by an expectation that the connection is fully established whenconnect()returns.As per discussion in issue #521