Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test on newer Pythons; enable Python dev mode #771

Merged
merged 5 commits into from
Dec 23, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Dec 21, 2023

@akx akx force-pushed the test-on-newer-pythons branch 7 times, most recently from 55efbc4 to fea2a25 Compare December 23, 2023 08:28
@akx
Copy link
Contributor Author

akx commented Dec 23, 2023

@PierreF Rebased, ready for review.

.github/workflows/tox.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the addition of PYTHONDEVMODE -- Cool!

@PierreF
Copy link
Contributor

PierreF commented Dec 23, 2023

The PR looks fine, we just broke "python setup.py test" command.
I'm not sure whether is really used (I think the the release process, which might use use). Anyway, I'll have a look at #774 which should both cause few conflict with this PR and remove "setup.py" completely.

@cclauss
Copy link
Contributor

cclauss commented Dec 23, 2023

https://setuptools.pypa.io/en/latest/deprecated/commands.html

running python setup.py directly as a script is considered deprecated.
This also means that users should avoid running commands directly via python setup.py <command>.

@akx
Copy link
Contributor Author

akx commented Dec 23, 2023

Yeah, breaking setup.py test was on purpose – there's no reference to it anywhere in the repo (other than in the makefile), so I figured it wasn't really needed (anymore)... But yeah, #774 will get rid of setup.py altogether.

@PierreF
Copy link
Contributor

PierreF commented Dec 23, 2023

Confirmed that setup.py is not used for release, at least not how I do release (which I should document somewhere).

My process is currently:

  • testing by calling tox (inside a Docker image python:3.x)
  • testing linter by calling tox
  • tag & push tag
  • build and upload to PyPi (using make upload)

Therefor this PR seems fine for me.

akx and others added 5 commits December 23, 2023 20:27
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Signed-off-by: Aarni Koskela <akx@iki.fi>
Co-authored-by: Christian Clauss <cclauss@me.com>
Signed-off-by: Aarni Koskela <akx@iki.fi>
@akx
Copy link
Contributor Author

akx commented Dec 23, 2023

My process is currently: ...

If it helps, the procedure I've built for python-babel is pretty slick these days – everything is done on GitHub Actions, and I just okay the release (via the release GHA environment requiring an accept gate). See https://github.com/python-babel/babel/blob/master/.github/workflows/ci.yml

@PierreF
Copy link
Contributor

PierreF commented Dec 23, 2023

That true that making a release on CI is better than locally, as it ensure your local environment don't affect the release. I take not of your workflow and will consider it.

@PierreF PierreF merged commit 3d26fa6 into eclipse:master Dec 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants