Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct object as client protocol #821

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Return correct object as client protocol #821

merged 1 commit into from
Mar 24, 2024

Conversation

asikeero
Copy link
Contributor

Fixes #820

@PierreF
Copy link
Contributor

PierreF commented Feb 29, 2024

Thanks for catching this error. Could you sign ECA (https://accounts.eclipse.org/user/eca / https://www.eclipse.org/legal/ECA.php) so I can merge you PR ?

@asikeero
Copy link
Contributor Author

Done, should be OK now.

@asikeero
Copy link
Contributor Author

asikeero commented Mar 6, 2024

Two checks are failing due to reasons that seem not to relate to this PR. Just to clarify, am I expected to add something to this PR to make them pass?

@PierreF
Copy link
Contributor

PierreF commented Mar 24, 2024

Thanks for your patience. Pytest (tox) tend to be have false-positive errors (cf #789). The lint_python error is a real error, linked to your change.
Your change isn't the issue actually, but make the issue visible: self._protocol is not correctly typed.

I'll merge your PR and fix the typing once merged.

Thanks for your contribution.

@PierreF PierreF merged commit 96cf6d9 into eclipse:master Mar 24, 2024
8 of 10 checks passed
@PierreF PierreF added this to the 2.1.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading Client protocol property causes infinite recursion loop
2 participants