Fix eclipse/rdf4j#1293 optimizer for regex calls now handles non-var arguments #171
Conversation
JervenBolleman
force-pushed
the
1293
branch
3 times, most recently
from
360ebb5
to
011f369
Compare
|
I am sorry for all the force pushes I am trying to get IP-validation part correct. |
… other string functions Signed-off-by: Jerven Bolleman <jerven.bolleman@sib.swiss>
|
good to see you got the signing issues fixed :) I |
...ain/java/org/eclipse/rdf4j/query/algebra/evaluation/impl/RegexAsStringFunctionOptimizer.java
Show resolved
Hide resolved
|
Should we consider targeting this at master and push it out with the 2.5 release? |
|
Also. What happens to Jenkins? Shouldn’t it be posting here asking if it needs to build and test this PR? |
|
@hmottestad (on my phone so forgive brevity) I'm not sure why it's not doing that, but you or Bart should be able to ping it by commenting '@rdf4j-bot run tests' |
|
@rdf4j-bot run tests |
|
On a conference but I have a few spare minutes right now, I'll take a look at jenkins and why it's not picking up this PR |
abrokenjester
changed the title
|
@rdf4j-bot run tests |
|
Right, looks like I forgot to add you as an admin for the Jenkins PR config for rdf4j-storage, @hmottestad - that's why it ignored you. I've added you so the magic phrase should work for you too, from now on. FWIW Jenkins only automatically builds PRs from users that have been whitelisted, and Jerven hasn't yet. |
|
Unfortunately this can not be easily rebased to the master branch as it was implemented off of a post-3.0 version of the develop branch. If we want to include it in 2.5, we'll need to cherrypick. |
|
Merged into develop and cherry picked into master. |
This PR addresses GitHub issue: eclipse-rdf4j/rdf4j#1293 .
The previous optimizer for replacing regex calls with contains,strstarts or strends did not work if the argument to the Regex was not a var.
e.g. REGEX(STR(?x), 'lala')
was not optimized.
This fixes this and adds a test for it.