This repository has been archived by the owner on Feb 22, 2020. It is now read-only.
#1294: unit test for txncache file system leak (Windows only) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This unit tests reveals a leak in the handling of txncache.dat files which do not get cleaned up on Windows due to file locking. Signed-off-by: Andreas Schwarte <aschwarte10@gmail.com>
|
See ecllipse/rdf4j#1295 for the proposed fix after which the unit tests no longer fails |
|
@jeenbroekstra please comment if this is the right location for such test. |
|
@aschwarte10 @barthanssens no objection to this merge, but for future reference: this kind of test should in future just be in the nativestore module itself, in src/test/java, I think. |
barthanssens
added a commit
that referenced
this pull request
Feb 15, 2019
…-unitTest #1294: unit test for txncache file system leak (Windows only)
barthanssens
added a commit
that referenced
this pull request
Feb 15, 2019
…urceLeak-unitTest" This reverts commit 3ac504a. Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
abrokenjester
pushed a commit
that referenced
this pull request
Feb 16, 2019
…urceLeak-unitTest" This reverts commit b292180.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses GitHub issue: eclipse-rdf4j/rdf4j#1294 .
This unit tests reveals a leak in the handling of txncache.dat files
which do not get cleaned up on Windows due to file locking.