-
Notifications
You must be signed in to change notification settings - Fork 12
Issues/#30 commands help #40
Issues/#30 commands help #40
Conversation
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
I've rebased this to the develop branch and scheduled it for 2.4.0 release. Let me know if that works for you Bart. |
Thanks James, works for me :-) |
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
…matting Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a lot cleaner, good stuff. There's code formatting issues though. IIRC @barthanssens you are not using Eclipse IDE, correct? It might be worth looking at how to port our Eclipse code formatting settings to your IDE, could also be useful for other RDF4J devs that use a different IDE.
} else { | ||
consoleIO.writeError("Unknown target '" + tokens[1] + "'"); | ||
consoleIO.writeError("Unknown target '" + tokens[1] + "'"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a code formatting issue. @barthanssens can you check your indent settings (or if you're using Eclipse, make sure the project is set to use the predefined RDF4J code formatting settings?). Looks to me like it adds a second tab in a conditional block.
More generally it might be good for a dev who uses eclipse to run reformatting on this PR.
Thanks, I'll fix the formatting issues |
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
This PR addresses GitHub issue: #30 .
Briefly describe the changes proposed in this PR: