Skip to content
This repository has been archived by the owner on Feb 22, 2020. It is now read-only.

Issues/#30 commands help #40

Merged
merged 31 commits into from
May 6, 2018
Merged

Issues/#30 commands help #40

merged 31 commits into from
May 6, 2018

Conversation

barthanssens
Copy link
Contributor

@barthanssens barthanssens commented Mar 29, 2018

This PR addresses GitHub issue: #30 .

Briefly describe the changes proposed in this PR:

  • Move command line parsing to new class CmdLineParser (reducing the lines of code in Console class)
  • Move commands to separate (sub)package to make a better distinction
  • Move short description and help text to the commands (instead of a separate PrintHelp file with constants)
  • Let all commands inherit from new ConsoleCommand class (which implements the old Command interface + new Help interface)
    • This also includes the QueryEvaluator (with two new small sparql and serql classes, making them "normal" commands as well, instead of special cases)
  • Order commands alphabetically

Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@catch-point catch-point added this to the 2.4.0 milestone Apr 2, 2018
@catch-point catch-point changed the base branch from master to develop April 2, 2018 15:38
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@catch-point
Copy link

I've rebased this to the develop branch and scheduled it for 2.4.0 release. Let me know if that works for you Bart.

@barthanssens
Copy link
Contributor Author

Thanks James, works for me :-)
I'll use the 2.4 dev branch for the other things I'm working on (#21 and #43)

Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
…matting

Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Copy link
Member

@abrokenjester abrokenjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot cleaner, good stuff. There's code formatting issues though. IIRC @barthanssens you are not using Eclipse IDE, correct? It might be worth looking at how to port our Eclipse code formatting settings to your IDE, could also be useful for other RDF4J devs that use a different IDE.

} else {
consoleIO.writeError("Unknown target '" + tokens[1] + "'");
consoleIO.writeError("Unknown target '" + tokens[1] + "'");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a code formatting issue. @barthanssens can you check your indent settings (or if you're using Eclipse, make sure the project is set to use the predefined RDF4J code formatting settings?). Looks to me like it adds a second tab in a conditional block.

More generally it might be good for a dev who uses eclipse to run reformatting on this PR.

@barthanssens
Copy link
Contributor Author

Thanks, I'll fix the formatting issues
(and indeed, I'm currently using NetBeans instead of Eclipse, probably forgot to run the formatter / activate the Eclipse formatting rules)

Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
Signed-off-by: Bart Hanssens <bart.hanssens@bosa.fgov.be>
@abrokenjester abrokenjester merged commit 1b7d1cc into eclipse:develop May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants