Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snakeyaml to 2.0 #2198

Closed
akurtakov opened this issue Mar 14, 2023 · 9 comments
Closed

Update snakeyaml to 2.0 #2198

akurtakov opened this issue Mar 14, 2023 · 9 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement
Milestone

Comments

@akurtakov
Copy link
Contributor

This release fixes CVE https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-1471 according to https://bitbucket.org/snakeyaml/snakeyaml/wiki/Changes

@jukzi
Copy link

jukzi commented Jun 1, 2023

Currently reddeer requires org.yaml.snakeyaml;bundle-version="1.14.0":
https://github.com/search?q=repo%3Aeclipse%2Freddeer+snakeyaml&type=code

Currrent Eclipse IDE ships 1.27 from orbit. All those versions are reported to have multiple vulnerabilities.:
https://mvnrepository.com/artifact/org.yaml/snakeyaml
image

Would you please require snakeyaml 2.0?

@odockal odockal added this to the 4.6.0 milestone Jun 2, 2023
@odockal odockal added dependencies Pull requests that update a dependency file enhancement labels Jun 2, 2023
@odockal odockal self-assigned this Jun 2, 2023
@akurtakov
Copy link
Contributor Author

@merks Could you please help this project with setting up proper usage of maven central artifacts?

@merks
Copy link

merks commented Jun 22, 2023

I will look into it now.

@merks
Copy link

merks commented Jun 22, 2023

I'm kind of confused where the dependencies come from. I can't find a *.target file. Searching all the files doesn't even clue me in to where the dependency might be specified...

merks@CORE MINGW64 /d/Users/merks/temp/reddeer
$grep snake $(find . -type f )
./NOTICE.md:snakeyaml (1.27.0)
./plugins/org.eclipse.reddeer.junit/META-INF/MANIFEST.MF: org.yaml.snakeyaml;bundle-version="1.14.0"
./plugins/org.eclipse.reddeer.junit/src/org/eclipse/reddeer/junit/internal/configuration/reader/JSONConfigurationReader.java:import org.yaml.snakeyaml.Yaml;
./plugins/org.eclipse.reddeer.junit/src/org/eclipse/reddeer/junit/internal/configuration/reader/JSONConfigurationReader.java:import org.yaml.snakeyaml.constructor.SafeConstructor;
./tests/org.eclipse.reddeer.integration.test/MANIFEST.MF: org.yaml.snakeyaml;bundle-version="1.14.0"

@akurtakov
Copy link
Contributor Author

akurtakov commented Jun 22, 2023

Instead of target file the project defines p2 sites in the pom.xml e.g. https://github.com/eclipse/reddeer/blob/master/pom.xml#L208 .
Switching the project to target file is probably better as it's kind of standard.

@merks
Copy link

merks commented Jun 22, 2023

Reddeer could use https://download.eclipse.org/oomph/simrel-orbit/2023-09 which aggregates Orbit's IBuild (currently with all the direct-from-Maven dependencies of all the SimRel projects, already PGP signed. It contains the following versions:

image

I assume, given there is no upper bound on the dependency in the MANIFEST.MF, the build would just pick up the 2.0.0 version automatically. Of course this update site will update to minor versions "automatically", and at some point soon, this will be provided/hosted by Orbit's downloads.

Okay?

@odockal
Copy link
Member

odockal commented Jun 27, 2023

@merks @akurtakov I have prepared PR to tackle this issue. #2206. although I like the site Ed proposed. I will work that in.

@odockal odockal modified the milestones: 4.6.0, 4.7.0 Jul 18, 2023
odockal added a commit to odockal/reddeer that referenced this issue Jul 18, 2023
…fixes eclipse#2198

Signed-off-by: Ondrej Dockal <odockal@redhat.com>
@akurtakov
Copy link
Contributor Author

Do you plan new release soon? It would be nice to have one so this old snakeyaml disappears through the transitive deps updates for 2023-09.

@olkornii
Copy link
Contributor

@akurtakov we are working on new release (4.7.0): #2216 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

No branches or pull requests

5 participants