refactor: Overfitting detection as an AbstractRepairStep component

[andre15silva]

Closes #1135

Why not a separate pipeline step?

Currently repair steps call recordPatches when they finish their work, which calls the notifiers. If, after that, we have logic that can filter/rank/etc the patches, it messes up that logic.

What is there to finish?

Are the patch ranking methods for ODS working (tests are ignored). If so, wouldn't it make more sense to have different modes for the different features? Instead of OVERFITTING we would have ODS_P4J and ODS_S4R for example. @monperrus wdyt?

Also, should ranking be done inside each repair step or overall? The later makes more sense to me, but would require a separate step for it and would mess up the observer pattern mentioned above.

ChangeLog

• Add missing parameters to control patch ranking, filtering and classification to LauncherUtils and RepairnatorConfig. Update test accordingly.
• Move ranking (to finish), filtering and classification logic to a method in AbstractRepairStep. Update test accordingly. Ranking and filtering tests to be activated/written.

[monperrus]

Cool to make progress on this topic.

Are the patch ranking methods for ODS working (tests are ignored).

We can remove the ranking code (outdated plus not researched anymore). We'll start from scratch again with #1210

If so, wouldn't it make more sense to have different modes for the different features

No. We want to simply take the best feature set identified by @SophieHYe in the ODS paper.

[andre15silva]

This is ready. The only test failing is a flaky test (identified in #1176 )

[monperrus]

Thanks. What's the intention behind PATCH_FILTERING_MODE?

[monperrus]

The only test failing is a flaky tes

Could you remove / deflakify it in a separate PR? Thanks!

[andre15silva]

Thanks. What's the intention behind PATCH_FILTERING_MODE?

In the case there is a new filtering mode in the future (in the case there are more than one filtering options for the same classification mode), the developer will just need to add a new mode.

Could you remove / deflakify it in a separate PR? Thanks!

Done. Opened #1214

[andre15silva]

Ready

[monperrus]

Great, thanks.