[Astro] added support for duplicate identification to avoid unnecessa…

…ry discovery results (#4611) * added support for duplicate identification to avoid unnecessary discovery results Signed-off-by: Kai Kreuzer <kai@openhab.org>
eclipse-archived · Nov 24, 2017 · 31911b1 · 31911b1
1 parent b6b3ce5
commit 31911b1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/extensions/binding/org.eclipse.smarthome.binding.astro/ESH-INF/thing/moon.xml b/extensions/binding/org.eclipse.smarthome.binding.astro/ESH-INF/thing/moon.xml
@@ -26,6 +26,9 @@
 			<channel-group id="position" typeId="position" />
 			<channel-group id="zodiac" typeId="moonZodiac" />
 		</channel-groups>
+
+		<representation-property>geolocation</representation-property>
+
 		<config-description-ref uri="thing-type:astro:config" />
 	</thing-type>
 

diff --git a/extensions/binding/org.eclipse.smarthome.binding.astro/ESH-INF/thing/sun.xml b/extensions/binding/org.eclipse.smarthome.binding.astro/ESH-INF/thing/sun.xml
@@ -54,6 +54,9 @@
 			<channel-group id="eclipse" typeId="sunEclipse" />
 			<channel-group id="phase" typeId="sunPhase" />
 		</channel-groups>
+
+		<representation-property>geolocation</representation-property>
+
 		<config-description-ref uri="thing-type:astro:config" />
 	</thing-type>
 

diff --git a/...in/java/org/eclipse/smarthome/binding/astro/internal/discovery/AstroDiscoveryService.java b/...in/java/org/eclipse/smarthome/binding/astro/internal/discovery/AstroDiscoveryService.java
@@ -117,9 +117,9 @@ public void createResults(PointType location) {
             propGeolocation = String.format("%s,%s", location.getLatitude(), location.getLongitude());
         }
         thingDiscovered(DiscoveryResultBuilder.create(sunThing).withLabel("Local Sun")
-                .withProperty("geolocation", propGeolocation).build());
+                .withProperty("geolocation", propGeolocation).withRepresentationProperty("geolocation").build());
         thingDiscovered(DiscoveryResultBuilder.create(moonThing).withLabel("Local Moon")
-                .withProperty("geolocation", propGeolocation).build());
+                .withProperty("geolocation", propGeolocation).withRepresentationProperty("geolocation").build());
     }
 
     @Reference