Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Commit

Permalink
Renamed a few packages to internal in the org.eclipse.smarthome.io.re…
Browse files Browse the repository at this point in the history
…st.core bundle. (#4225)

See openhab/static-code-analysis#100

Signed-off-by: VelinYordanov <velin.iordanov@gmail.com>
  • Loading branch information
VelinYordanov authored and kaikreuzer committed Sep 21, 2017
1 parent ae86aa4 commit b41ab36
Show file tree
Hide file tree
Showing 30 changed files with 51 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.discovery
package org.eclipse.smarthome.io.rest.core.internal.discovery

import static org.junit.Assert.*

Expand All @@ -19,6 +19,7 @@ import org.eclipse.smarthome.core.thing.ThingRegistry
import org.eclipse.smarthome.core.thing.ThingUID
import org.eclipse.smarthome.core.thing.binding.builder.ThingBuilder
import org.eclipse.smarthome.core.thing.type.ThingTypeRegistry
import org.eclipse.smarthome.io.rest.core.internal.discovery.InboxResource
import org.eclipse.smarthome.test.OSGiTest
import org.junit.Before
import org.junit.Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import static org.junit.Assert.*

import javax.ws.rs.core.Response

import org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceResource
import org.eclipse.smarthome.io.rest.core.internal.service.ConfigurableServiceResource
import org.eclipse.smarthome.test.OSGiTest
import org.junit.After
import org.junit.Before
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.item;
package org.eclipse.smarthome.io.rest.core.internal.item;

import static org.hamcrest.CoreMatchers.*;
import static org.junit.Assert.assertThat;
Expand All @@ -20,6 +20,8 @@
import org.eclipse.smarthome.core.types.StateDescription;
import org.eclipse.smarthome.core.types.StateDescriptionProvider;
import org.eclipse.smarthome.core.types.StateOption;
import org.eclipse.smarthome.io.rest.core.item.EnrichedItemDTO;
import org.eclipse.smarthome.io.rest.core.item.EnrichedItemDTOMapper;
import org.eclipse.smarthome.test.java.JavaOSGiTest;
import org.junit.Before;
import org.junit.Test;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.item;
package org.eclipse.smarthome.io.rest.core.internal.item;

import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.collection.IsCollectionWithSize.hasSize;
Expand All @@ -31,6 +31,7 @@
import org.eclipse.smarthome.core.items.dto.GroupItemDTO;
import org.eclipse.smarthome.core.library.items.DimmerItem;
import org.eclipse.smarthome.core.library.items.SwitchItem;
import org.eclipse.smarthome.io.rest.core.internal.item.ItemResource;
import org.eclipse.smarthome.test.java.JavaOSGiTest;
import org.junit.Before;
import org.junit.Test;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,14 @@ Import-Package:
org.eclipse.smarthome.io.rest,
org.eclipse.smarthome.io.rest.core.item,
org.eclipse.smarthome.io.rest.core.thing,
org.eclipse.smarthome.io.rest.core.persistence,
org.osgi.framework,
org.osgi.service.cm,
org.osgi.service.component,
org.slf4j
Export-Package: org.eclipse.smarthome.io.rest.core.config,
org.eclipse.smarthome.io.rest.core.persistence,
org.eclipse.smarthome.io.rest.core.service,
org.eclipse.smarthome.io.rest.core.item,
org.eclipse.smarthome.io.rest.core.thing
Service-Component: OSGI-INF/*.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
http://www.eclipse.org/legal/epl-v10.html
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.binding.BindingResource">
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.internal.binding.BindingResource">
<implementation class="org.eclipse.smarthome.io.rest.core.binding.BindingResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.binding.BindingResource"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.thing.ChannelTypeResource">
<implementation class="org.eclipse.smarthome.io.rest.core.channel.ChannelTypeResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.channel.ChannelTypeResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.channel.ChannelTypeResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setConfigDescriptionRegistry" cardinality="0..1" interface="org.eclipse.smarthome.config.core.ConfigDescriptionRegistry" name="ConfigDescriptionRegistry" policy="dynamic" unbind="unsetConfigDescriptionRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.config.ConfigDescriptionResource">
<implementation class="org.eclipse.smarthome.io.rest.core.config.ConfigDescriptionResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.config.ConfigDescriptionResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.config.ConfigDescriptionResource"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceResource">
<implementation class="org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.service.ConfigurableServiceResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.service.ConfigurableServiceResource"/>
</service>
<reference bind="setConfigurationService" cardinality="0..1" interface="org.eclipse.smarthome.io.rest.core.config.ConfigurationService" name="ConfigurationService" policy="dynamic" unbind="unsetConfigurationService"/>
<reference bind="setConfigDescriptionRegistry" cardinality="0..1" interface="org.eclipse.smarthome.config.core.ConfigDescriptionRegistry" name="ConfigDescriptionRegistry" policy="dynamic" unbind="unsetConfigDescriptionRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@
http://www.eclipse.org/legal/epl-v10.html
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.discovery.DiscoveryResource">
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.internal.discovery.DiscoveryResource">
<implementation class="org.eclipse.smarthome.io.rest.core.discovery.DiscoveryResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.discovery.DiscoveryResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.discovery.DiscoveryResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setDiscoveryServiceRegistry" cardinality="0..1" interface="org.eclipse.smarthome.config.discovery.DiscoveryServiceRegistry" name="DiscoveryServiceRegistry" policy="dynamic" unbind="unsetDiscoveryServiceRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<implementation class="org.eclipse.smarthome.io.rest.core.extensions.ExtensionResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.extensions.ExtensionResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.extensions.ExtensionResource"/>
</service>
<reference bind="addExtensionService" cardinality="0..n" interface="org.eclipse.smarthome.core.extension.ExtensionService" name="ExtensionService" policy="dynamic" unbind="removeExtensionService"/>
<reference bind="setEventPublisher" cardinality="0..1" interface="org.eclipse.smarthome.core.events.EventPublisher" name="EventPublisher" policy="dynamic" unbind="unsetEventPublisher"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.discovery.InboxResource">
<implementation class="org.eclipse.smarthome.io.rest.core.discovery.InboxResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.discovery.InboxResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.discovery.InboxResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.discovery.InboxResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setInbox" cardinality="0..1" interface="org.eclipse.smarthome.config.discovery.inbox.Inbox" name="Inbox" policy="dynamic" unbind="unsetInbox"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.link.ItemChannelLinkResource">
<implementation class="org.eclipse.smarthome.io.rest.core.link.ItemChannelLinkResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.link.ItemChannelLinkResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.link.ItemChannelLinkResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.link.ItemChannelLinkResource"/>
</service>
<reference bind="setItemChannelLinkRegistry" cardinality="0..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="dynamic" unbind="unsetItemChannelLinkRegistry"/>
<reference bind="setThingLinkManager" cardinality="0..1" interface="org.eclipse.smarthome.core.thing.link.ThingLinkManager" name="ThingLinkManager" policy="dynamic" unbind="unsetThingLinkManager"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" immediate="true" name="org.eclipse.smarthome.io.rest.core.item">
<implementation class="org.eclipse.smarthome.io.rest.core.item.ItemResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.item.ItemResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.item.ItemResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setItemRegistry" cardinality="0..1" interface="org.eclipse.smarthome.core.items.ItemRegistry" name="ItemRegistry" policy="dynamic" unbind="unsetItemRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" immediate="true" name="org.eclipse.smarthome.core.persistence.internal.rest">
<implementation class="org.eclipse.smarthome.io.rest.core.persistence.PersistenceResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.persistence.PersistenceResource"/>
<reference bind="setItemRegistry" cardinality="1..1" interface="org.eclipse.smarthome.core.items.ItemRegistry" name="ItemRegistry" policy="dynamic" unbind="unsetItemRegistry"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.thing.ThingResource">
<implementation class="org.eclipse.smarthome.io.rest.core.thing.ThingResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.thing.ThingResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.thing.ThingResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.thing.ThingResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setItemChannelLinkRegistry" cardinality="0..1" interface="org.eclipse.smarthome.core.thing.link.ItemChannelLinkRegistry" name="ItemChannelLinkRegistry" policy="dynamic" unbind="unsetItemChannelLinkRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@
-->
<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.1.0" name="org.eclipse.smarthome.io.rest.core.thing.ThingTypeResource">
<implementation class="org.eclipse.smarthome.io.rest.core.thing.ThingTypeResource"/>
<implementation class="org.eclipse.smarthome.io.rest.core.internal.thing.ThingTypeResource"/>
<service>
<provide interface="org.eclipse.smarthome.io.rest.core.thing.ThingTypeResource"/>
<provide interface="org.eclipse.smarthome.io.rest.core.internal.thing.ThingTypeResource"/>
<provide interface="org.eclipse.smarthome.io.rest.RESTResource"/>
</service>
<reference bind="setConfigDescriptionRegistry" cardinality="0..1" interface="org.eclipse.smarthome.config.core.ConfigDescriptionRegistry" name="ConfigDescriptionRegistry" policy="dynamic" unbind="unsetConfigDescriptionRegistry"/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.binding;
package org.eclipse.smarthome.io.rest.core.internal.binding;

import java.io.IOException;
import java.net.URI;
Expand Down Expand Up @@ -41,7 +41,7 @@
import org.eclipse.smarthome.io.rest.RESTResource;
import org.eclipse.smarthome.io.rest.Stream2JSONInputStream;
import org.eclipse.smarthome.io.rest.core.config.ConfigurationService;
import org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceResource;
import org.eclipse.smarthome.io.rest.core.internal.service.ConfigurableServiceResource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.channel;
package org.eclipse.smarthome.io.rest.core.internal.channel;

import java.util.ArrayList;
import java.util.List;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.config;
package org.eclipse.smarthome.io.rest.core.internal.config;

import java.net.URI;
import java.net.URISyntaxException;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.discovery;
package org.eclipse.smarthome.io.rest.core.internal.discovery;

import java.util.Collection;
import java.util.LinkedHashSet;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.discovery;
package org.eclipse.smarthome.io.rest.core.internal.discovery;

import java.util.stream.Stream;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.extensions;
package org.eclipse.smarthome.io.rest.core.internal.extensions;

import java.net.URI;
import java.net.URISyntaxException;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.item;
package org.eclipse.smarthome.io.rest.core.internal.item;

import java.util.ArrayList;
import java.util.Collection;
Expand Down Expand Up @@ -61,6 +61,8 @@
import org.eclipse.smarthome.io.rest.LocaleUtil;
import org.eclipse.smarthome.io.rest.RESTResource;
import org.eclipse.smarthome.io.rest.Stream2JSONInputStream;
import org.eclipse.smarthome.io.rest.core.item.EnrichedItemDTO;
import org.eclipse.smarthome.io.rest.core.item.EnrichedItemDTOMapper;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.link;
package org.eclipse.smarthome.io.rest.core.internal.link;

import java.util.stream.Stream;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.persistence;
package org.eclipse.smarthome.io.rest.core.internal.persistence;

import java.util.ArrayList;
import java.util.Date;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.service;
package org.eclipse.smarthome.io.rest.core.internal.service;

import java.io.IOException;
import java.net.URI;
Expand Down Expand Up @@ -36,6 +36,7 @@
import org.eclipse.smarthome.io.rest.RESTResource;
import org.eclipse.smarthome.io.rest.core.config.ConfigurationService;
import org.eclipse.smarthome.io.rest.core.internal.RESTCoreActivator;
import org.eclipse.smarthome.io.rest.core.service.ConfigurableServiceDTO;
import org.osgi.framework.Constants;
import org.osgi.framework.InvalidSyntaxException;
import org.osgi.framework.ServiceReference;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.thing;
package org.eclipse.smarthome.io.rest.core.internal.thing;

import java.io.IOException;
import java.net.URI;
Expand Down Expand Up @@ -79,6 +79,8 @@
import org.eclipse.smarthome.io.rest.LocaleUtil;
import org.eclipse.smarthome.io.rest.RESTResource;
import org.eclipse.smarthome.io.rest.Stream2JSONInputStream;
import org.eclipse.smarthome.io.rest.core.thing.EnrichedThingDTO;
import org.eclipse.smarthome.io.rest.core.thing.EnrichedThingDTOMapper;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* which accompanies this distribution, and is available at
* http://www.eclipse.org/legal/epl-v10.html
*/
package org.eclipse.smarthome.io.rest.core.thing;
package org.eclipse.smarthome.io.rest.core.internal.thing;

import java.util.ArrayList;
import java.util.Collection;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import org.eclipse.smarthome.core.transform.TransformationHelper;
import org.eclipse.smarthome.core.types.StateDescription;
import org.eclipse.smarthome.io.rest.core.internal.RESTCoreActivator;
import org.eclipse.smarthome.io.rest.core.internal.item.ItemResource;

/**
* The {@link EnrichedItemDTOMapper} is a utility class to map items into enriched item data transform objects (DTOs).
Expand Down

0 comments on commit b41ab36

Please sign in to comment.