Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Greyed out validation markers in Designer #2190

Closed
kaikreuzer opened this issue Sep 19, 2016 · 15 comments · Fixed by #2873 or #2891
Closed

Greyed out validation markers in Designer #2190

kaikreuzer opened this issue Sep 19, 2016 · 15 comments · Fixed by #2873 or #2891

Comments

@kaikreuzer
Copy link
Contributor

Items are not resolved in the Designer, i.e. when trying to use content completion e.g. in sitemaps, no proposals show up.

@mhilbush
Copy link
Contributor

The items list in the lower left of the designer window also is not populated with items. Could this be another symptom of the above problem?

@kaikreuzer
Copy link
Contributor Author

Yes, other symptom of the same root cause.

@rkoshak
Copy link

rkoshak commented Oct 13, 2016

I'm also not having any of my Items identified in my Rules. Actions are also not recognized in Rules (below is a screenshot showing createTimer and logInfo . Hovering over the error it says "The method logInfo(String, String) is undefined".

image

@J-N-K
Copy link
Contributor

J-N-K commented Nov 10, 2016

This is broken since commit 0b3f1f3 (#1828), I guess the ModelParser needs to be enabled in the Designer. However I didn't find out how to do so.

@kohlsalem
Copy link

I installed yesterday the latest snapshot of the designer - and my rules look pretty much like the image posted by rkoshak.

@kaikreuzer , since this seems to be an open issue for quite a while now, and Highlightig/Check/TypeAread are the only reasons to use the Designer, can i conclude this part of the project to be dead? Since more and more functionality moves into the GUI, i would understand that, I'm just curious....

@kaikreuzer
Copy link
Contributor Author

@kohlsalem I would love to see this fixed myself, but I don't know how to do it (at least without spending quite some amount of time, which I simply do not have) and nobody else came up with a fix yet either.

So please help finding people that are deep in Eclipse RCP and Xtext and that are willing to give a hand here!

sjsf pushed a commit to sjsf/smarthome that referenced this issue Jan 20, 2017
...in order to fix the registry population with elements.

fixes eclipse-archived#2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@sjsf
Copy link
Contributor

sjsf commented Jan 20, 2017

no in-depth Xtext knowledge was needed. Just some unhappy services...

kaikreuzer pushed a commit that referenced this issue Jan 23, 2017
...in order to fix the registry population with elements.

fixes #2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@kaikreuzer
Copy link
Contributor Author

Re-opening as I still have issues with the rule resolution:

screen shot 2017-01-23 at 16 09 16

@kaikreuzer kaikreuzer reopened this Jan 23, 2017
@sjsf
Copy link
Contributor

sjsf commented Jan 24, 2017

Yes, indeed, I can confirm that rules are still awfully broken. Will have a look too.

sjsf pushed a commit to sjsf/smarthome that referenced this issue Jan 24, 2017
...in the dynamically created project.

fixes eclipse-archived#2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@sjsf
Copy link
Contributor

sjsf commented Jan 24, 2017

As it turned out there was a package imported twice in they dynamically created project, leading to an invalid manifest which could not resolve any classes except those from the JRE. I have created #2891 in order to prevent this. Could you please check if that solves your issues?

@ThomDietrich
Copy link
Contributor

Somewhat related question: How complicated would it be to export what's special about the Designer as an eclipse ide plugin?

@kaikreuzer
Copy link
Contributor Author

Could you please check if that solves your issues?

Not entirely. The error markers still appear when opening a rule and are greyed our shortly after. So it's a good step forward, but not yet there.

How complicated would it be to export what's special about the Designer as an eclipse ide plugin?

You mean like #630? To much effort and and it wouldn't solve any concrete issue.

maggu2810 pushed a commit that referenced this issue Jan 25, 2017
...in the dynamically created project.

fixes #2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@kaikreuzer kaikreuzer reopened this Jan 25, 2017
@ThomDietrich
Copy link
Contributor

ThomDietrich commented Feb 6, 2017

@SJKA I can confirm that the problems are not entirely solved yet.
The good news: Item resolution is working again and valid rules are without errors.

In the following screenshots you can see the "greyed out error markers" @kaikreuzer was mentioning before. Any chance you could have yet another look? Thanks ;)

grafik

grafik

chaton78 pushed a commit to chaton78/smarthome that referenced this issue May 7, 2017
...in order to fix the registry population with elements.

fixes eclipse-archived#2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
chaton78 pushed a commit to chaton78/smarthome that referenced this issue May 7, 2017
...in the dynamically created project.

fixes eclipse-archived#2190
Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>
@sjsf
Copy link
Contributor

sjsf commented May 22, 2017

I just had another look at it (sorry it fell off my desk...). I think I figured out the reason for the greyed out markers: The script and model runtimes trigger another validation, interfering with the same resources that are displayed in the editors. So while in #2873 the items runtime bundle was necessary to fix the item resolution, the rules and script runtime should not have been added. I will propose a fix for it.

@kaikreuzer
Copy link
Contributor Author

I think we will live with this greyed out validation markers and not put further effort in the designer, see https://dev.eclipse.org/mhonarc/lists/smarthome-dev/msg00146.html.
If anybody out there would like to work on it, feel free to do so and we can re-open the issue.

@kaikreuzer kaikreuzer changed the title Item resolution broken in Designer Greyed out validation markers in Designer Aug 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants