This repository has been archived by the owner on May 7, 2020. It is now read-only.
Correct ERROR log messages in HTTP action #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this doesn't pass the "minimal change exception" for PRs, I can sign off on a new commit. |
|
Yeah, please sign it off, would be the cleanest - thanks! |
It seems that the intent was to print a string message of the exception, but since the last argument is the exception its stack trace is being dumped instead. Signed-off-by: John Cocula <john@cocula.com>
|
passed ip-validation now |
|
perfect. |
chaton78
pushed a commit
to chaton78/smarthome
that referenced
this pull request
Dec 23, 2016
It seems that the intent was to print a string message of the exception, but since the last argument is the exception its stack trace is being dumped instead. Signed-off-by: John Cocula <john@cocula.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the intent was to print a string message of the exception, but since the last argument is the exception its stack trace is being dumped instead.
Noticed on the forum here.