Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

Basic UI: dynamic update of the frame title #3526

Merged
merged 1 commit into from
May 30, 2017
Merged

Basic UI: dynamic update of the frame title #3526

merged 1 commit into from
May 30, 2017

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@triller-telekom
Copy link
Contributor

I just tested this PR and somehow it doesn't work for me or I am using the wrong configuration:

items:

Group:Switch:OR(ON, OFF)        Lights "All Lights [(%s)]"

Switch L1    "Ceiling"       (Lights)
Switch L2    "Floor"       (Lights)

sitemap:

sitemap demo label="Demo Sitemap" {
	Frame label="Demo Items" {
		Group item=Lights
	}
}

On the first age of the basicui I see "All Lights (ON/Off)" and this does update itself immediately if i use the console to trigger it, i.e. "smarthome update L1 ON"
However, If i click on the group and then see L1 and L2 with a frame title "All Lights (ON/Off)" the status is not updated immediately if I use the console to trigger it.

@lolodomo
Copy link
Contributor Author

No. I am fixing another bug when you have in your sitemap something like "Frame item=Lights".
Your case is another bug, the update of the page title. I have not yet fixed this other bug.

@triller-telekom
Copy link
Contributor

Thank you for the clarification. Indeed this PR is updating the frame title immediately, I have just tested it.

@kaikreuzer kaikreuzer merged commit 599f981 into eclipse-archived:master May 30, 2017
@lolodomo lolodomo deleted the frame_title branch May 30, 2017 16:07
@kaikreuzer kaikreuzer modified the milestone: 0.9.0 Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants