Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things file #3772

Merged
merged 1 commit into from Jun 30, 2017

Conversation

Projects
None yet
2 participants
@wborn
Copy link
Contributor

commented Jun 29, 2017

As reported in #3745 using powerOnBrightness= in a .things file no longer works. Such files nowadays fail validation, e.g. the following warning is logged:

19:04:22.457 [WARN ] [el.core.internal.ModelRepositoryImpl] - Configuration model 'test.things' has errors, therefore ignoring it: [4,49]: no viable alternative at input ']'

After testing it shows that removing the default for the powerOnBrightness parameter makes it again possible to switch lights on without changing the brightness when the powerOnBrightness parameter in .things files is omitted.

LIFX: Fix #3745 powerOnBrightness is ignored when empty in the things…
… file

Signed-off-by: Wouter Born <eclipse@maindrain.net>
@kaikreuzer
Copy link
Member

left a comment

Makes indeed much more sense, thanks!

@kaikreuzer kaikreuzer merged commit 2565ad7 into eclipse:master Jun 30, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@wborn wborn deleted the wborn:3745-lifx-bugfix branch Jun 30, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

@kaikreuzer kaikreuzer added the bug label Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.