Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[astro] Tidy up set of scheduled futures #3811

Merged
merged 1 commit into from Jul 7, 2017

Conversation

Projects
None yet
3 participants
@sjka
Copy link
Contributor

commented Jul 6, 2017

...in order to not keep useless references to finished jobs in the collections.

It's taking the opportunity for tidying up every time a new job gets scheduled.
In that way, the job's runnables don't have to be cluttered with these
internals of the handler.

Note: while it is in principle is similar to #3809, the current version since #3776 does not cause such troubles anymore. So this PR is mainly about freeing a little bit of memory.

Signed-off-by: Simon Kaufmann simon.kfm@googlemail.com

[astro] Tidy up set of scheduled futures
...in order to not keep useless references to finished jobs in the collections.

It's taking the opportunity for tyding up every time a new job gets scheduled.
In that way, the job's runnables don't have to be cluttered with these
internals of the handler.

Signed-off-by: Simon Kaufmann <simon.kfm@googlemail.com>

@sjka sjka added the Binding-Astro label Jul 6, 2017

@triller-telekom
Copy link
Contributor

left a comment

LGTM

@kaikreuzer kaikreuzer merged commit 8af6f61 into eclipse:master Jul 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

@kaikreuzer kaikreuzer added the bug label Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.