Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaptToLeader calculates leaveSpeed depending on one time step #11106

Closed
Domsall opened this issue Jul 1, 2022 · 4 comments
Closed

AdaptToLeader calculates leaveSpeed depending on one time step #11106

Domsall opened this issue Jul 1, 2022 · 4 comments

Comments

@Domsall
Copy link
Contributor

Domsall commented Jul 1, 2022

In the following example, vehicle_0 is on a minor link and would like to drive onto the junction 2927559855.
The gap between vehicle_2 and vehicle_3 should be large enough for vehicle_0 to do this, but vehicle_0 actually waits for vehicle_3 to pass.

What I found out when debugging:

This issue probably only gets exposed in subsecond simulations.

A test case showing this issue: AdaptToLeader_LeaveSpeed.zip

SUMO-version: 1.13.0 and 1.10.0

operating system: Windows 10

@Domsall Domsall changed the title AdaptToLeader overwrites leaveSpeed AdaptToLeader calculates leaveSpeed depending on one time step Jul 1, 2022
@Domsall
Copy link
Contributor Author

Domsall commented Aug 29, 2022

I actually uploaded a test as zip in the previous comment :)

@namdre
Copy link
Contributor

namdre commented Sep 1, 2022

The problem is described in #11265 (comment)

@namdre namdre closed this as completed in 9533f39 Sep 1, 2022
namdre added a commit that referenced this issue Sep 1, 2022
namdre added a commit that referenced this issue Sep 1, 2022
namdre added a commit that referenced this issue Sep 1, 2022
@Domsall
Copy link
Contributor Author

Domsall commented Sep 1, 2022

The issue was unfortunately not resolved for my use case.

The calculated estimatedLeaveSpeed (in the above example Line 2710) is approx. 6 m/s. This is used when vehicle_1 does not exist. Result: vehicle_0 drives over the junction.

The calculated futureVSafe (or the old vsafeLeader in Line 2929) uses the current speed or the speed after one time step to update LeaveSpeed, which is approx. 0.25/0.5 m/s. Result: vehicle_0 does not drive over the junction (because of high leaveTime in MSLink::blockedByFoe).

@namdre namdre reopened this Sep 1, 2022
@namdre
Copy link
Contributor

namdre commented Sep 1, 2022

Even test test I added for this issue still shows the problem (though many other tests show improved traffic).

@namdre namdre closed this as completed in afa16cd Sep 1, 2022
namdre added a commit that referenced this issue Sep 1, 2022
namdre added a commit that referenced this issue Sep 2, 2022
Domsall added a commit to Domsall/sumo that referenced this issue Sep 8, 2022
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
Domsall added a commit to Domsall/sumo that referenced this issue Sep 8, 2022
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
Domsall added a commit to Domsall/sumo that referenced this issue Sep 8, 2022
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
namdre pushed a commit that referenced this issue Sep 12, 2022
* Adding CalcReason CURR/FUT to stop/follow/freeSpeed

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Add FUTURE to #11106 change

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Adding remaining CalcReasons, updating EIDM

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Changes to adaptToJunctionLeader for ReasonForCall

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Update tests

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Undo test/debug code

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Fix #11106 gComputeLC usage in CF Code

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Insertion-calls should be FUTURE

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Update tests

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Revert AdaptToJunctionLeader changes

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Update tests

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Fix correct inputs of maximumSafeFollowSpeed

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Missing inputs of maximumSafeFollowSpeed

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

* Revert maximumSafeFollowSpeed-changes

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>

Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants