-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdaptToLeader calculates leaveSpeed depending on one time step #11106
Comments
I actually uploaded a test as zip in the previous comment :) |
The problem is described in #11265 (comment) |
The issue was unfortunately not resolved for my use case. The calculated The calculated |
Even test test I added for this issue still shows the problem (though many other tests show improved traffic). |
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
* Adding CalcReason CURR/FUT to stop/follow/freeSpeed Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Add FUTURE to #11106 change Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Adding remaining CalcReasons, updating EIDM Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Changes to adaptToJunctionLeader for ReasonForCall Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Update tests Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Undo test/debug code Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Fix #11106 gComputeLC usage in CF Code Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Insertion-calls should be FUTURE Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Update tests Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Revert AdaptToJunctionLeader changes Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Update tests Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Fix correct inputs of maximumSafeFollowSpeed Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Missing inputs of maximumSafeFollowSpeed Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> * Revert maximumSafeFollowSpeed-changes Signed-off-by: Dominik Salles <dominik.salles@fkfs.de> Signed-off-by: Dominik Salles <dominik.salles@fkfs.de>
In the following example,
vehicle_0
is on a minor link and would like to drive onto the junction2927559855
.The gap between
vehicle_2
andvehicle_3
should be large enough forvehicle_0
to do this, butvehicle_0
actually waits forvehicle_3
to pass.What I found out when debugging:
vehicle_1
) does not exist,vehicle_0
has not problem crossing the junction.leaveSpeed
calculation without a leader results in a well estimated value and is done here: https://github.com/eclipse/sumo/blob/31b2a739c7a6751f50a8718222ffb22869243f05/src/microsim/MSVehicle.cpp#L2710leaveSpeed
inadaptToLeader
with a value fromfollowSpeed
:https://github.com/eclipse/sumo/blob/31b2a739c7a6751f50a8718222ffb22869243f05/src/microsim/MSVehicle.cpp#L2929
This issue probably only gets exposed in subsecond simulations.
A test case showing this issue: AdaptToLeader_LeaveSpeed.zip
SUMO-version: 1.13.0 and 1.10.0
operating system: Windows 10
The text was updated successfully, but these errors were encountered: