Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add phase property 'name' #4788

Closed
7 tasks done
namdre opened this issue Nov 14, 2018 · 2 comments
Closed
7 tasks done

add phase property 'name' #4788

namdre opened this issue Nov 14, 2018 · 2 comments
Assignees
@namdre
Labels
a:netconvert a:netedit a:sumo a:sumo-gui c:input c:traci enhancement
Milestone
1.2.0

Comments

@namdre
Copy link
Contributor

namdre commented Nov 14, 2018 •
edited
Loading

to allow for arbitrary user annoted phase descriptions

  • load into sumo
  • show in gui
  • get/set via traci
  • preserve when loading/saving network
  • edit with netedit
  • support in sumolib
  • documentation
@namdre namdre self-assigned this Nov 14, 2018
@namdre namdre added the c:traci label Nov 14, 2018
@palvarezlopez
Copy link
Member

@namdre "phase " should be treated as a GNEAttributeCarrier?

@namdre
Copy link
Contributor Author

namdre commented Nov 14, 2018

The whole Traffic light should be treated as an attribute carrier eventually but this is a whole other issue. Right now, things can stay as they are and 'name' treated like the other phase attributes.
The netedit changes should come after the netconvert/sumo changes anway.

@namdre namdre removed the p:minor label Jan 7, 2019
@namdre namdre added this to the 1.2.0 milestone Jan 7, 2019
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
can now show optional phase name in gui. refs #4788
c963e75
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
added traci support for phase name (also affects completeDefinition c…
e374b96 
…ommands). now supported by python and C++ clients. refs #4788
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
added traci tests. refs #4788
b1b4982
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
added Trafficlight methods getPhaseName and setPhaseName. refs #4788
ac9999d
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
added netconvert tests refs #4788
4bfe60c
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
now preserving phase attributes 'next' and 'name'. refs #4788
65b3f25
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
added sumolib test refs #4788
d5e2dc8
namdre added a commit that referenced this issue Jan 7, 2019
@namdre
now loading phase name in sumolib. refs #4788
651aaa4
namdre added a commit that referenced this issue Jan 10, 2019
@namdre
patching expected results refs #21, #4788
3effdf4
namdre added a commit that referenced this issue Jan 11, 2019
@namdre
can now edit phase attributes next and name in netedit. refs #4788
d35b931
@namdre namdre closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namdre namdre

Labels
a:netconvert a:netedit a:sumo a:sumo-gui c:input c:traci enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@namdre @palvarezlopez