Fixes for Issues #43 and #44 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/Transformer.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/Transformer.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/Transformer.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
...eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/SignatureRuleImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
...eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/SignatureRuleImpl.java
Outdated
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Show resolved
Hide resolved
tbitonti
reviewed
Jun 30, 2020
...eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/SignatureRuleImpl.java
Outdated
Show resolved
Hide resolved
|
Hi; reviewed the initial update. Looks fine. I have a number of comments, above, but all of the comments are for minor issues. |
|
@tbitonti , thank-you for your review I fixed them all. I have also added a unit test. I am wandering if the count of constant changes is correct. We are counting it both in UTF8 and in ConstantString, so that doubles the number. I checked with Direct String and it is the same. |
|
@bjhargrave This looks good to me. Can you take a quick look before merging? |
bjhargrave
requested changes
Jul 10, 2020
org.eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/ClassActionImpl.java
Outdated
Show resolved
Hide resolved
...clipse.transformer.cli/src/main/java/org/eclipse/transformer/jakarta/JakartaTransformer.java
Outdated
Show resolved
Hide resolved
...eclipse.transformer/src/main/java/org/eclipse/transformer/action/impl/SignatureRuleImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: JF Denise <jdenise@redhat.com>
jfdenise
force-pushed
the
wf-fixes
branch
2 times, most recently
from
93a8972
to
cfc6eb5
Compare
Signed-off-by: JF Denise <jdenise@redhat.com>
bjhargrave
approved these changes
Jul 13, 2020
|
Thanks! |
This was
linked to
issues
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant string transformation (#44) and on fix for Annotation Element value of type String (#43).
A user would define a master index such as:
org/jboss/as/jaxrs/JaxrsAnnotations$Constants.class=jaxrs-annotations.properties
org/apache/jasper/compiler/Generator.class=jsp-compiler.properties
org/jboss/as/weld/CdiAnnotations$Constants.class=cdi-annotations.properties
Each properties file would then contain specific mapping for the class.
Note that the transformation also looks inside complex String to replace parts.
Added unit test.
Signed-off-by: JF Denise jdenise@redhat.com