Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better failure logging when handleMessage failes #1802

Closed
rscorer opened this issue Feb 8, 2017 · 1 comment
Closed

Better failure logging when handleMessage failes #1802

rscorer opened this issue Feb 8, 2017 · 1 comment

Comments

@rscorer
Copy link

rscorer commented Feb 8, 2017

In eclipse/vert.x/src/main/java/io/vertx/core/eventbus/impl/HandlerRegistration.java in method deliver there is a catch block which could be improved slightly.

It has been advantageous to me to see the address of the message handler which has failed (for whatever reason)

    } catch (Exception e) {
      log.error("Failed to handleMessage ", e);
      metrics.endHandleMessage(metric, e);
      throw e;
      if (message != null) {
        log.error("Failed to handleMessage '" + message.address() + "'", e);
      } else {
        log.error("Failed to handleMessage ", e);
      }

So now if my event handler "service.releaseaccount" has a failure I am told so by name, which could be quite useful

@jan-zajic
Copy link
Contributor

PR #1896. Null check is useless as message method called about 9 rows above.

@vietj vietj closed this as completed in 8e6e306 Mar 24, 2017
vietj added a commit that referenced this issue Mar 24, 2017
FIX #1802 - Better failure logging when handleMessage failes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants