NetServer rework #1771
Merged
NetServer rework #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
reviewed
Jan 20, 2017
| * @return the net server metrics SPI | ||
| */ | ||
| TCPMetrics<?> createMetrics(NetServer server, SocketAddress localAddress, NetServerOptions options); | ||
| TCPMetrics<?> createMetrics(SocketAddress localAddress, NetServerOptions options); |
There was a problem hiding this comment.
Have you checked if this is used in Metrics impl ?
There was a problem hiding this comment.
Even if it's not, a breaking change notice is mandatory
There was a problem hiding this comment.
yes, I'll record a line for that in change log
There was a problem hiding this comment.
I don't think it is used because NetServer only provides useless stuff : listen / close / handler, so it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide the
NetServerBasethat manages the state of a TCP server that is extracted fromNetServerImplin order to reuse it in vertx-mqtt-server that will benefit of its feature. The vertx-mqtt-server is based on Netty's MQTT codec.