Improve the redeploy documentation #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly mention the —java-opts parameter used to configure the forked process. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
jponge
approved these changes
May 2, 2017
src/main/asciidoc/java/index.adoc
Outdated
| @@ -1235,14 +1235,15 @@ java io.vertx.core.Launcher run org.acme.MyVerticle --redeploy="**/*.class" --l | |||
|
|
|||
| The redeployment process is implemented as follows. First your application is launched as a background application | |||
| (with the `start` command). On matching file changes, the process is stopped and the application is restarted. | |||
| This way avoids leaks. | |||
| This way avoids leaks (as the process is restarted). | |||
There was a problem hiding this comment.
Simplify:
This avoids leaks, as the process is restarted.
There was a problem hiding this comment.
Wrong place for my comments, should be in package-info.java
src/main/asciidoc/java/index.adoc
Outdated
| @@ -1272,7 +1273,14 @@ java -jar build/libs/my-fat-jar.jar --redeploy="src/**/*.java" --on-redeploy='./ | |||
|
|
|||
| The "on-redeploy" option specifies a command invoked after the shutdown of the application and before the | |||
| restart. So you can hook your build tool if it updates some runtime artifacts. For instance, you can launch `gulp` | |||
| or `grunt` to update your resources. | |||
| or `grunt` to update your resources. Don't forget that passing parameter to your application requires the | |||
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
|
Thanks @jponge! I've updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly mention the --java-opts parameter used to configure the forked process.
This issue is related to #1960 (and hopefully fix it)