-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the redeploy documentation #1961
Conversation
Explicitly mention the —java-opts parameter used to configure the forked process. Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minor straightforward comments
src/main/asciidoc/java/index.adoc
Outdated
@@ -1235,14 +1235,15 @@ java io.vertx.core.Launcher run org.acme.MyVerticle --redeploy="**/*.class" --l | |||
|
|||
The redeployment process is implemented as follows. First your application is launched as a background application | |||
(with the `start` command). On matching file changes, the process is stopped and the application is restarted. | |||
This way avoids leaks. | |||
This way avoids leaks (as the process is restarted). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify:
This avoids leaks, as the process is restarted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong place for my comments, should be in package-info.java
src/main/asciidoc/java/index.adoc
Outdated
@@ -1272,7 +1273,14 @@ java -jar build/libs/my-fat-jar.jar --redeploy="src/**/*.java" --on-redeploy='./ | |||
|
|||
The "on-redeploy" option specifies a command invoked after the shutdown of the application and before the | |||
restart. So you can hook your build tool if it updates some runtime artifacts. For instance, you can launch `gulp` | |||
or `grunt` to update your resources. | |||
or `grunt` to update your resources. Don't forget that passing parameter to your application requires the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter_s_
Signed-off-by: Clement Escoffier <clement.escoffier@gmail.com>
Thanks @jponge! I've updated the PR. |
Explicitly mention the --java-opts parameter used to configure the forked process.
This issue is related to #1960 (and hopefully fix it)