Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST calls to the org.eclipse.vorto.repository.web.core.ModelSearchController can be replaced by direct calls to the API search controller #2142

Closed
ghost opened this issue Dec 5, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented Dec 5, 2019

Following the search improvement task and the removal of one endpoint in the specific search controller in package org.eclipse.vorto.repository.web.core, it would be coherent to remove the other endpoint as well ("/public"), and thus the whole controller could be obsoleted.

The front-end issuing REST calls to it ("tenantManagement.js" in the "repository-web" module) could directly call the search with "./api/v1/search/models?expression=visibility:Public".

@aedelmann the one thing I am not able to figure out at this time, is how exactly this endpoint is used at all. The angular controller is referenced in the "admin-template.html" resource, but contrary to its sibling functionality I replaced, I cannot trigger the REST call at all.
The javadoc in ModelSearchController does not help, since it only seems to refer to the namespace functionality.
Any thoughts?

@ghost
Copy link
Author

ghost commented Dec 5, 2019

Pull request here.
As mentioned above, I could not find an actual case where this was used, so I am (maybe blindly) assuming that this was, in fact, not used at all.
@aedelmann if you know for a fact I am wrong on this assumption, please let me know so I can test the change practically (it is a trivial change, but a little testing wouldn't hurt).

@ghost ghost closed this as completed Jan 10, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants