Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze "user upgrade" functionality and consider whether it can be removed #2708

Open
ghost opened this issue Nov 18, 2020 · 0 comments
Open

Comments

@ghost
Copy link

ghost commented Nov 18, 2020

The /update endpoint is mapped to a basic UI and a front-end controller calling /rest/accounts/{username:.+}/updateTask.

The latter in the AccountController invokes the functionalities in the DefaultUpgradeService, which at this time, seem to only provide an abstraction framework for some user account upgrade tasks.

I haven't found yet whether there is any automatic/conditional redirection of a user's request to that endpoint.

It also looks like there is some confusion in between upgrading a user account (which would suggest some role changes to me) and the tasks currently implemented, which suggest updates to model content (Vortolang etc. ) - i.e. not the user itself.

Generally speaking, it seems this was thought of as a "glue" to allow automatic migration of older data formats.

The code is pretty old (mostly 2018 - early 2019), and could use an in-depth review on whether we still need it at all.

@ghost ghost added the Refactoring label Nov 18, 2020
@ghost ghost changed the title Analyze and likely remove the "user upgrade" functionality Analyze "user upgrade" functionality and consider whether it can be removed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants